thiagoelg commented on code in PR #3630: URL: https://github.com/apache/incubator-kie-tools/pull/3630#discussion_r3436717612
########## .github/pull_request_template.md: ########## @@ -0,0 +1,60 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +> ▼▼▼ **Delete this entire section before opening your PR** ▼▼▼ + +Related Issue: Link to the GitHub issue this PR addresses. For maintenance, infrastructure, or minor changes without an associated issue, `NO-ISSUE:` is acceptable. + +Example title format: `<issue-reference>: [<component>] <descriptive action>` + +Issue reference can be either: + +- `kie-issues#xxxx:` +- `NO-ISSUE:` + +To automatically close the issue when this PR is merged, use keywords like: + +- Closes apache/incubator-kie-issues#xxxx +- Fixes apache/incubator-kie-issues#xxxx +- Resolves apache/incubator-kie-issues#xxxx + +> ▲▲▲ **Delete this entire section before opening your PR** ▲▲▲ + +## Summary + +Describe the changes in this PR. + +## Checklist + +- [ ] PR is linked to an existing GitHub issue, or uses `NO-ISSUE:` for maintenance/infrastructure/minor changes +- [ ] PR title follows `<issue-reference>: [<component>] <descriptive action>` +- [ ] Ran `pnpm bootstrap` +- [ ] Ran production build with E2E tests and container images (see **CONTRIBUTING.md**) +- [ ] All relevant tests pass +- [ ] Added Apache License 2.0 headers to new files +- [ ] Updated documentation if behavior changes +- [ ] Verified no unintended files were modified + +## Breaking changes + +List any breaking changes, if applicable. + +## Testing notes + +Add any relevant testing details, if applicable. Review Comment: Yeah, it bothers me as well 😞 , but PRs with little to no description also bother me a lot. Maybe we could be more incisive when reviewing PRs and asking for a more detailed description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
