tkobayas commented on code in PR #6768:
URL:
https://github.com/apache/incubator-kie-drools/pull/6768#discussion_r3449486813
##########
drools-core/src/main/java/org/drools/core/phreak/PhreakRuleTerminalNode.java:
##########
@@ -113,6 +113,7 @@ public static void doLeftTupleInsert(ReteEvaluator
reteEvaluator,
// most recent PropagationContext is required to maintain the right
recency which triggers the match
PropagationContext pctx = leftTuple.findMostRecentPropagationContext();
if ( rtnNode.getRule().isNoLoop() && sameRules(rtnNode,
pctx.getTerminalNodeOrigin()) ) {
+ executor.addDormantTuple(leftTuple);
Review Comment:
When the tuple is suppressed because of `no-loop`, the tuple was not belong
to activeMatches nor dormantMatches. This is how it became orphan in the NPE
case.
Explicitly add it to dormantMatches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
