gitgabrio opened a new issue, #2352: URL: https://github.com/apache/incubator-kie-issues/issues/2352
In the [Annotate "properties"](https://github.com/apache/incubator-kie-issues/issues/2349) task a couple of annotations have been introduced: `KieProperty` and `KieInternal`. `KieProperty` should be used to identify properties that are meant to be configurable by users (e.g. as `system properties` or inside `application.properties` file). In the above task automatically-discovered properties have been annotated, with some manual intervention to differentiate between `KieProperty` and `KieInternal`. But that left out some issues, namely: 1. not all "configuration" properties have been detected; i.e. 2. only ´public static final String´ with initializer and javadoc annotation have been annotated 3. some configuration properties are "dynamically" generated by concatenation/formatting in (at least) two different ways a. raw String concatenation; e.g. `public static final String PROPERTY = SOME_PREFIX + "_a property" b. on-the-fly format; e.g. `return String.format("prefix.%s", aString)` Scope of this task is to amend the above issues: 1. identify and properly annotate all missing "configuration" properties 2. refactor all the "composed" properties to have them statically defined; this latter task would imply some bit of duplication and code refactoring, but eventually it should increase overall readability/maintainability of the code @baldimir @Rikkola @tkobayas @pefernan @martinweiler @yesamer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
