tkobayas commented on code in PR #6774:
URL:
https://github.com/apache/incubator-kie-drools/pull/6774#discussion_r3472123438
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/TimerAndCalendarWithPseudoTimeTest.java:
##########
@@ -298,6 +298,13 @@ public void
testMalformedCronExpression(KieBaseTestConfiguration kieBaseTestConf
wrongTimerExpression(kieBaseTestConfiguration, "cron: 0/30 * * * * *");
}
+ @ParameterizedTest(name = "KieBase type={0}")
+ @MethodSource("parameters")
+ @Timeout(10000)
+ public void testLargeRangeValueInCronExpression(KieBaseTestConfiguration
kieBaseTestConfiguration) {
Review Comment:
outdated
##########
drools-core/src/main/java/org/drools/core/time/impl/KieCronExpression.java:
##########
@@ -798,6 +798,11 @@ protected void addToSet(int val, int end, int incr, int
type)
TreeSet set = getSet(type);
+ if (val == ALL_SPEC_INT && (end != -1 || incr < 0)) {
+ throw new ParseException(
+ "Wildcard value is not valid as a range bound", -1);
+ }
Review Comment:
outdated
##########
drools-core/src/main/java/org/drools/core/time/impl/KieCronExpression.java:
##########
@@ -798,6 +798,11 @@ protected void addToSet(int val, int end, int incr, int
type)
TreeSet set = getSet(type);
+ if (val == ALL_SPEC_INT && (end != -1 || incr < 0)) {
+ throw new ParseException(
+ "Wildcard value is not valid as a range bound", -1);
+ }
Review Comment:
outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
