yesamer commented on code in PR #6776:
URL:
https://github.com/apache/incubator-kie-drools/pull/6776#discussion_r3527420016
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/ast/DMNDecisionServiceEvaluator.java:
##########
@@ -84,8 +93,9 @@ public EvaluatorResult evaluate(DMNRuntimeEventManager
eventManager, DMNResult r
}
}
boolean typeCheck = ((DMNRuntimeImpl)
eventManager.getRuntime()).performRuntimeTypeCheck(result.getModel());
+ Object finalResult = decisionIDs.size() == 1 ?
ctx.values().iterator().next() : ctx;
if (typeCheck) {
- Object c = DMNRuntimeUtils.coerceUsingType(decisionIDs.size() == 1
? ctx.values().iterator().next() : ctx,
+ Object c = DMNRuntimeUtils.coerceUsingType(finalResult,
Review Comment:
ok, but you changed the scope of the finalResult variable, previously it was
managed inside the if, now is outside, is that necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]