martinweiler commented on code in PR #4330:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4330#discussion_r3624126342
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/SLAComplianceTest.java:
##########
@@ -85,17 +89,17 @@ public void afterSLAViolated(SLAViolatedEvent event) {
boolean slaViolated = latch.await(10, TimeUnit.SECONDS);
assertThat(slaViolated).as("SLA was not violated while it is
expected").isTrue();
- processInstance =
kruntime.getProcessInstance(processInstance.getStringId());
-
assertThat(processInstance.getState()).isEqualTo(KogitoProcessInstance.STATE_ACTIVE);
+ processInstance =
processDefinition.instances().findById(processInstance.id()).orElse(null);
+ assertThat(processInstance).isNotNull();
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_ACTIVE);
- int slaCompliance =
getSLAComplianceForProcessInstance(processInstance);
-
assertThat(slaCompliance).isEqualTo(KogitoProcessInstance.SLA_VIOLATED);
+ int slaCompliance = executeInWorkflowState(processInstance, p ->
p.getSlaCompliance());
+
assertThat(slaCompliance).isEqualTo(org.kie.api.runtime.process.ProcessInstance.SLA_VIOLATED);
-
kruntime.getKogitoWorkItemManager().completeWorkItem(workItem.getStringId(),
null);
- assertProcessInstanceFinished(processInstance, kruntime);
+ ProcessTestHelper.completeWorkItem(processInstance,
Collections.emptyMap(), "john");
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
- slaCompliance = getSLAComplianceForProcessInstance(processInstance);
-
assertThat(slaCompliance).isEqualTo(KogitoProcessInstance.SLA_VIOLATED);
+
assertThat(processSlaCompliance.get()).isEqualTo(org.kie.api.runtime.process.ProcessInstance.SLA_VIOLATED);
Review Comment:
Why do we need the listener approach here instead of querying the
`slaCompliance` directly from the processInstance, similar to how it is done in
lines 96-97?
It would also be possible to adapt the `getSLAComplianceForProcessInstance`
method to the new style and use it throughout the test case. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
