SUNILathulya commented on code in PR #6833:
URL:
https://github.com/apache/incubator-kie-drools/pull/6833#discussion_r3671316287
##########
kogito-jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/SLAComplianceTest.java:
##########
@@ -225,109 +248,6 @@ public void afterProcessCompleted(ProcessCompletedEvent
event) {
assertThat(nodeSlaCompliance.get()).isEqualTo(org.kie.api.runtime.process.ProcessInstance.SLA_MET);
}
- @Test
- public void testSLAonProcessViolatedExternalTracking() throws Exception {
- CountDownLatch latch = new CountDownLatch(1);
- final KogitoProcessEventListener listener = new
DefaultKogitoProcessEventListener() {
-
- @Override
- public void afterSLAViolated(SLAViolatedEvent event) {
- latch.countDown();
- }
-
- };
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/sla/BPMN2-UserTaskWithSLA.bpmn2");
-
- TestWorkItemHandler workItemHandler = new TestWorkItemHandler();
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human
Task", workItemHandler);
- kruntime.getProcessEventManager().addEventListener(listener);
- kruntime.getKieRuntime().getEnvironment().set("SLATimerMode", "false");
Review Comment:
@martinweiler ,
Removed useTimerSLATracking() method from
[WorkflowProcessInstanceImpl](vscode-webview://0heov295j8pspmdtctdj189adt9cvnm73p72sb0g9cr0bkgb2dq8/kogito-jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/impl/WorkflowProcessInstanceImpl.java:1249)
— it read SLATimerMode from the environment, which was only used by the
removed tests
Inlined the default behaviour — registerTimer() is now always called
unconditionally, which was the behaviour when SLATimerMode was null.
Fix available at
[4f6f01e](https://github.com/apache/incubator-kie-drools/pull/6833/commits/4f6f01e77b3004465e6da83ffb813935ea3d1a5d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
