martinweiler commented on code in PR #6852:
URL:
https://github.com/apache/incubator-kie-drools/pull/6852#discussion_r3684539509
##########
kogito-data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/JPAAbstractQuery.java:
##########
@@ -85,4 +93,124 @@ protected <T> List<T>
executeWithQueryEntityManagerAndArguments(EntityManager en
return jpaQuery.getResultList();
}
+
+ @SuppressWarnings("unchecked")
+ protected <T> List<T> executeIsolated(
+ EntityManager entityManager,
+ String queryName,
+ Map<String, Object> arguments,
+ Optional<Processes> processesOpt,
+ String processIdColumn,
+ String processVersionColumn,
+ String rootProcessIdColumn,
+ String rootProcessVersionColumn) {
+
+ String baseQuery =
MappingFile.findInFile("META-INF/data-audit-orm.xml", entityManager, queryName);
+ return executeIsolatedQuery(entityManager, baseQuery, arguments,
processesOpt,
+ processIdColumn, processVersionColumn, rootProcessIdColumn,
rootProcessVersionColumn);
+ }
+
+ @SuppressWarnings("unchecked")
+ protected <T> List<T> executeIsolatedQuery(
+ EntityManager entityManager,
+ String baseQuery,
+ Map<String, Object> arguments,
+ Optional<Processes> processesOpt,
+ String processIdColumn,
+ String processVersionColumn,
+ String rootProcessIdColumn,
+ String rootProcessVersionColumn) {
+
+ Map<String, Object> params = new HashMap<>(arguments);
+ Map<String, Object> pagination = (Map<String, Object>)
params.remove("pagination");
+
+ List<ProcessKey> allowedKeys = resolveAllowedKeys(processesOpt);
+ String finalQuery = applyIsolationFilter(baseQuery, allowedKeys,
+ processIdColumn, processVersionColumn, rootProcessIdColumn,
rootProcessVersionColumn);
+
+ LOGGER.debug("About to execute isolated native query {} with arguments
{}", finalQuery, params);
+ Query jpaQuery = entityManager.createNativeQuery(finalQuery);
+
+ params.forEach(jpaQuery::setParameter);
+
+ bindIsolationParameters(jpaQuery, allowedKeys);
+
+ if (pagination != null) {
Review Comment:
This logic is missing the `offset` parameter. Please reuse the logic from
`executeWithQueryEntityManagerAndArguments`, ideally extract into a common
method to be used in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
