Adarshvk98 opened a new pull request, #3690: URL: https://github.com/apache/incubator-kie-tools/pull/3690
Closes https://github.com/apache/incubator-kie-issues/issues/2385 `workspaces-git-fs` can now sign the commits it creates. Signatures come from an implementation of the new `CommitSigner` interface, which is passed to the workspaces worker when it is constructed. On push, commits created earlier that have not yet reached the remote are signed as well. ## What changed Paths below are relative to `packages/workspaces-git-fs/src/` New files: - `commitSigner/CommitSignerApi.ts` declares `CommitSigner`, an interface with one method, `sign({ payload, privateKey, passphrase? })`, which returns a signature. It also declares `SigningKeyConfig`, holding the private key and its optional passphrase. - `commitSigner/SigningArgs.ts` pairs a signer with its key config, and maps that pair onto isomorphic-git's `onSign` and `signingKey`. - `commitSigner/CommitHistorySigner.ts` signs commits that already exist but have not reached the remote, by recreating them with signatures. Changed files: - `services/GitService.tsx`: `commit` and `pull` take an optional `signing` argument and pass it to isomorphic-git. - `worker/WorkspacesWorkerApiImpl.ts`: takes an optional `commitSigner` when constructed. On push, when signing is configured, it signs the commits the remote does not have, then pushes. - `worker/api/WorkspacesWorkerGitApi.ts`, `context/WorkspacesContext.tsx` and `context/WorkspacesContextProvider.tsx`: declare an optional `signingConfig` on the git operations that create commits, and an optional `gitConfig` on push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
