Copilot commented on code in PR #6884:
URL: https://github.com/apache/incubator-kie/pull/6884#discussion_r3773393228
##########
drools-core/src/main/java/org/drools/core/util/DeserializationFilterHelper.java:
##########
@@ -35,7 +35,7 @@ public class DeserializationFilterHelper {
private static final Set<String> DEFAULT_ALLOWED_CLASSES = Set.of(
"org.drools.base.reteoo.InitialFactImpl",
- "org.drools.core.util.LinkedListEntry",
+ "org.drools.base.util.LinkedListEntry",
Review Comment:
Replacing the legacy class name makes previously persisted payloads
containing `org.drools.core.util.LinkedListEntry` fail this deserialization
filter; because the old class was also removed, they would fail class
resolution as well. This conflicts with the protobuf marshaller's stated
support for backward-compatible marshalled sessions. Preserve a compatible
legacy serialization bridge/read mapping, allow both old and new names during
migration, and cover loading an old-version fixture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
