tkobayas commented on code in PR #6860:
URL: https://github.com/apache/incubator-kie/pull/6860#discussion_r3794139729
##########
.github/workflows/ci.yaml:
##########
@@ -178,32 +152,90 @@ jobs:
# Affected pass (-pl affected): builds exactly the
affected modules (changed +
# transitive downstream),
running tests.
- - name: "PR CHECK :: BUILD :: Upstream modules${{ github.event_name ==
'push' && ' (skipped)' || '' }}"
- if: github.event_name == 'pull_request'
+ - name: "PR CHECK :: BUILD :: Upstream modules"
shell: bash
run: |
+ [ ! -s "$MAVEN_PL_AFFECTED_DROOLS_FILE" ] && echo "No affected
drools modules. Skipping upstream build." && exit 0
pl=$(paste -sd, "$MAVEN_PL_UPSTREAM_FILE")
[ -z "$pl" ] && echo "No upstream modules. Skipping." && exit 0
- mvn -T 1C --batch-mode --no-transfer-progress -fae -DskipTests
-DskipITs -Denforcer.skip=true -Dcheckstyle.skip=true -Dformatter.skip=true
-Darchunit.skip=true -Dsurefire.redirectTestOutputToFile=true -pl "$pl" install
+ mvn --batch-mode --no-transfer-progress -T 1C -fae -DskipTests
-DskipITs -Dquarkus.build.skip=true -Denforcer.skip=true -Dcheckstyle.skip=true
-Dformatter.skip=true -Darchunit.skip=true
-Dsurefire.redirectTestOutputToFile=true -pl "$pl" install
- - name: "PR CHECK :: BUILD :: Changed and affected modules${{
github.event_name == 'push' && ' (skipped)' || '' }}"
- if: github.event_name == 'pull_request'
+ - name: "PR CHECK :: TEST :: drools"
shell: bash
run: |
- pl=$(paste -sd, "$MAVEN_PL_AFFECTED_FILE")
- [ -z "$pl" ] && echo "No affected modules. Skipping." && exit 0
+ pl=$(paste -sd, "$MAVEN_PL_AFFECTED_DROOLS_FILE")
+ [ -z "$pl" ] && echo "No affected drools modules. Skipping." && exit 0
mvn --batch-mode --no-transfer-progress -fae
-Dsurefire.redirectTestOutputToFile=true -Dfull -Dreproducible -pl "$pl" install
Review Comment:
I don't use `-T 2` for the test phase because it will raise many issues, and
they will likely require a long time to fix (See
https://github.com/apache/incubator-kie/pull/6864).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
