jomarko commented on code in PR #3652: URL: https://github.com/apache/incubator-kie-tools/pull/3652#discussion_r3802384356
########## packages/bpmn-editor/tests-e2e/flowElements/connectionReanchorOnNodeMove.spec.ts: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { test, expect } from "../__fixtures__/base"; +import { JsonModel } from "../__fixtures__/jsonModel"; +import { NodeType } from "../__fixtures__/nodes"; + +// 0 = node's left border, 0.5 = centre (auto-anchored), 1 = right border. +async function getEndpointRelativeX(args: { + jsonModel: JsonModel; + nodeId: string; + direction: "incoming" | "outgoing"; +}): Promise<number> { + const flows = await args.jsonModel.getSequenceFlows(); + const flow = + args.direction === "incoming" + ? flows.find((f) => f["@_targetRef"] === args.nodeId) + : flows.find((f) => f["@_sourceRef"] === args.nodeId); + expect(flow).toBeTruthy(); + + const elements = (await args.jsonModel.getPlane())?.["di:DiagramElement"] ?? []; + const shape = elements.find( + (e: any) => e.__$$element === "bpmndi:BPMNShape" && e["@_bpmnElement"] === args.nodeId + ) as any; + const edge = elements.find( + (e: any) => e.__$$element === "bpmndi:BPMNEdge" && e["@_bpmnElement"] === flow!["@_id"] + ) as any; + + const bounds = shape["dc:Bounds"]; + const waypoints = edge["di:waypoint"]; + const endpoint = args.direction === "incoming" ? waypoints[waypoints.length - 1] : waypoints[0]; + + return (endpoint["@_x"] - bounds["@_x"]) / bounds["@_width"]; +} + +test.beforeEach(async ({ page, baseURL }) => { + await page.goto(`${baseURL}/iframe.html?args=&id=misc-connection-reanchor--start-to-end&viewMode=story`); + await expect(page.getByTestId("kie-bpmn-editor--diagram-container")).toBeVisible(); +}); + +test.describe("Connection - re-anchor on node move", () => { Review Comment: The only feedback I have is maybe we could add documentation for the test, some ASCI ART that show what was original diagram and what it was after the drag operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
