drccrd commented on code in PR #3717:
URL:
https://github.com/apache/incubator-kie-tools/pull/3717#discussion_r3806786619
##########
packages/drools-lsp/drools-lsp-server/src/main/java/org/drools/lsp/server/DroolsLspServer.java:
##########
@@ -214,8 +224,31 @@ public CompletableFuture<InitializeResult>
initialize(InitializeParams params) {
new DiagnosticRegistrationOptions(false, false));
initializeResult.getCapabilities().setTypeHierarchyProvider(true);
- String rootUri = params.getRootUri();
+ final String rootUri = params.getRootUri();
if (rootUri != null) {
+ String groupingSettings =
groupingSettingsOf(params.getInitializationOptions());
+ List<Path> workspaceFiles =
workspaceFilesOf(params.getInitializationOptions());
+ CompletableFuture.runAsync(() -> {
+ try {
+ // Let the grouping resolver read the workspace's
configuration
+ // before the classpath work below, which is the slow part.
+ WorkspaceSiblingResolver resolver =
WorkspaceSiblingResolvers.active();
Review Comment:
I think I would rate that finding as minor, not high, but one of the races
could be annoying if regularly encountered (I did not notice it during
functional testing).
Addressed by ordering the notifications and restricting group pin clearing
in 4d25f9f498f16299f7a2e4a60ccfdcf9c3755b46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
