martinweiler commented on code in PR #6888:
URL: https://github.com/apache/incubator-kie/pull/6888#discussion_r3813696979
##########
kogito-jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/ProcessVisitor.java:
##########
@@ -292,10 +337,9 @@ private void visitExceptionScope(Process process,
BlockStmt body) {
}
org.jbpm.workflow.core.WorkflowProcess workflowProcess =
(org.jbpm.workflow.core.WorkflowProcess) process;
Context context =
workflowProcess.getDefaultContext(ExceptionScope.EXCEPTION_SCOPE);
- //root process
+ // Root process exception scope only — sub-process node exception
scopes are
+ // handled inside visitNodes() where the node variable is still in
scope.
visitContextExceptionScope(context, body);
- //visit sub-processes
- visitSubExceptionScope(workflowProcess.getNodes(), body);
Review Comment:
Why are we changing the logic here? This seems unrelated to the node
handling changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
