drccrd commented on code in PR #3965:
URL:
https://github.com/apache/incubator-kie-tools/pull/3965#discussion_r3842224613
##########
packages/drools-lsp/drools-lsp-server/src/main/java/org/drools/lsp/server/DroolsLspDocumentService.java:
##########
@@ -106,11 +109,49 @@ public class DroolsLspDocumentService implements
TextDocumentService {
private final Map<String, String> sourcesMap = new ConcurrentHashMap<>();
private volatile ClassIndex classIndex = ClassIndex.empty();
private volatile ClassMemberIndex classMemberIndex =
ClassMemberIndex.empty();
+ private volatile JavaSourceTypeIndex javaSourceIndex =
JavaSourceTypeIndex.empty();
private final DroolsLspServer server;
public DroolsLspDocumentService(DroolsLspServer server) {
this.server = server;
+ // Lets binding resolution describe types the DRL does not declare, so
+ // hover and inlay hints work on Java fact classes. The closure reads
the
+ // live indexes on every call, so a rebuilt classpath needs no
re-install.
+ ClasspathTypeMembers.install(this::membersOfTypeName);
+ }
+
+ /**
+ * Members of the type named {@code typeName} as written in the DRL, with
+ * inherited members folded in — {@link ClassMemberIndex} reflects over the
+ * full hierarchy, and its source fallback walks the {@code extends} chain,
+ * so a superclass field resolves before and after a build. Empty when the
+ * name is unknown or ambiguous.
+ */
+ private List<Field> membersOfTypeName(String typeName) {
+ if (typeName == null || typeName.isEmpty()) {
+ return Collections.emptyList();
+ }
+ String fqcn = typeName.indexOf('.') >= 0
+ ? typeName
+ : uniqueFqcnForSimpleName(typeName);
+ return fqcn == null ? Collections.emptyList() :
classMemberIndex.membersOf(fqcn);
Review Comment:
This is a valid point, but I think the fail case is rare - having to classes
on path with the same simple name and different FQNs. The fix would be
difficult, but it would touch some files/interfaces not yet changed in this PR,
so I think it is something that can be tabled for another ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
