drccrd commented on code in PR #3718: URL: https://github.com/apache/incubator-kie-tools/pull/3718#discussion_r3850500746
########## packages/drools-lsp/drools-parser/pom.xml: ########## @@ -1,98 +0,0 @@ -<?xml version="1.0" encoding="UTF-8" ?> -<!-- - ~ Licensed to the Apache Software Foundation (ASF) under one - ~ or more contributor license agreements. See the NOTICE file - ~ distributed with this work for additional information - ~ regarding copyright ownership. The ASF licenses this file - ~ to you under the Apache License, Version 2.0 (the - ~ "License"); you may not use this file except in compliance - ~ with the License. You may obtain a copy of the License at - ~ - ~ http://www.apache.org/licenses/LICENSE-2.0 - ~ - ~ Unless required by applicable law or agreed to in writing, - ~ software distributed under the License is distributed on an - ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - ~ KIND, either express or implied. See the License for the - ~ specific language governing permissions and limitations - ~ under the License. - --> -<project - xmlns="http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"; -> - <modelVersion>4.0.0</modelVersion> - - <parent> - <groupId>org.kie.tools</groupId> - <artifactId>drools-lsp</artifactId> - <version>${revision}</version> - </parent> - - <artifactId>drools-parser</artifactId> - - <name>Drools :: Parser</name> Review Comment: This pom had fewer dependencies than `drools-drl-parser`, so switching brings `drools-core` - which adds substantially to the extension - particularly `drools-core` and `antlr-runtime` (other than drl-ast) if this is intentional then it changes what is possible in the vscode extension, but will also flag it in vscode's extension size warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
