Adarshvk98 opened a new pull request, #3989:
URL: https://github.com/apache/incubator-kie-tools/pull/3989

   ### Problem
   
   Opening a BPMN or DMN file inside a workspace leaves the editor on the 
loading screen. The extension host reports `TypeError: fsp._stat is not a 
function`.
   
   ### Root cause
   
   `ReadonlyIsomorphicGitFsForVsCodeWorkspaceFolders` declares 
`_original_unwrapped_fs`, which tells isomorphic-git to skip its own 
`FileSystem` wrapper and use the object as given. That wrapper is what normally 
creates the `_stat` and `_readFile` methods.
   
   isomorphic-git 1.36.0 and later call `discoverGitdir()` from `isIgnored()` 
before anything else, and `discoverGitdir()` uses `_stat`. The class never 
received it, so `isIgnored()` throws. 
`VsCodeResourceContentServiceForWorkspaces.list()` calls `isIgnored()` for 
every file in the workspace, so the whole call rejects and the editor never 
receives its file list.
   
   `packages/vscode-extension/package.json` declares `^1.30.1`, and 
`pnpm-lock.yaml` currently resolves to 1.38.10, which is within that range.
   
   ### Fix
   
   Add `_stat` and `_readFile` to the class, implemented against 
`vscode.workspace.fs`. Both work on 1.30.1 and on every later release, so the 
declared version range needs no change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to