nrknithin opened a new pull request, #2245:
URL: https://github.com/apache/incubator-kie-examples/pull/2245
**Related:** apache/incubator-kie#6903 (Quarkus 3.33.3.1 upgrade of the KIE
runtimes)
**Follows:** apache/incubator-kie-examples#2244 (merged — `0f4075b3`)
#2244 moved the shared build configuration out of the examples root pom into
the Quarkus and Spring Boot
aggregators, so the Maven examples now inherit their platform versions from
the kie BOMs. Two things it could not
cover are left:
1. **Gradle cannot inherit from a Maven parent.** The Gradle examples still
declare the Quarkus version literally,
and were still on 3.27.5.1.
2. **The root pom is the parent of the Java and Gradle trees only.** When
the shared `pluginManagement` moved into
the two aggregators, those trees lost pins they had been relying on.
## What changed
**`gradle-examples/kogito-quarkus-gradle-examples/{dmn-quarkus-gradle,process-decisions-rules-quarkus-gradle}/gradle.properties`**
- `quarkusPluginVersion` and `quarkusPlatformVersion` 3.27.5.1 →
**3.33.3.1**, matching `version.io.quarkus` in the
kie stack. The Spring Boot Gradle examples need no change:
`springBootVersion` 4.0.7 already matches what
`kogito-springboot/bom` declares.
**`pom.xml` (examples root)**
- restore `version.org.eclipse.jkube` 1.4.0 and `pluginManagement` entries
for `kubernetes-maven-plugin`,
`openshift-maven-plugin` and `maven-failsafe-plugin`
(`${version.surefire.plugin}`).
## Why those pins matter
Measured by diffing the effective POM of all 81 modules against `main`,
before restoring them:
- **`jkube` kubernetes/openshift-maven-plugin went from pinned 1.4.0 to
*unversioned*** in 9 modules (the root
aggregator, `kogito-java-examples`, and the Gradle trees) — precisely the
"Maven resolves the latest release"
hazard, which would make historical tags non-reproducible.
- **`maven-failsafe-plugin` silently dropped 3.3.1 → 3.2.5** in those same 9
modules, while `maven-surefire-plugin`
stayed at 3.3.1 — leaving the two mismatched within one build.
After this PR the only plugin-version differences against `main` are
intended:
| plugin | main → branch | modules |
|---|---|---|
| `quarkus-maven-plugin` | 3.27.5.1 → 3.33.3.1 | 63 (the upgrade itself) |
| `maven-resources-plugin` | 2.5 → 3.1.0 | 79 (the old root pom pinned a
2012 version) |
| `quarkus-extension-maven-plugin` | **unversioned** → 3.33.3.1 | 69 (a
float removed) |
| `quarkus-maven-plugin` | **unversioned** → 3.33.3.1 | 6 (a float removed) |
| `kogito-maven-plugin` | **unversioned** → 999-SNAPSHOT | 1 (a float
removed) |
## Verification
- `mvn validate` over the whole repository: **BUILD SUCCESS**, 81 modules,
zero
`'build.plugins.plugin.version' ... is missing` warnings, and the same
**5** RELEASE-resolved core plugins as
`main` — all of them in the parentless `kjar` examples under
`kogito-java-examples`, which is pre-existing.
- Effective-POM comparison of all 81 modules against `main`, as tabulated
above: no unintended version moved.
- Gradle: both examples build on the repository's Gradle **9.2.1** wrapper
with Quarkus 3.33.3.1 —
`gradlew clean test` → 8 tests, 0 failures, in each.
`io.quarkus.platform:quarkus-bom:3.33.3.1` is on Maven
Central and the 3.33.3.1 Gradle plugin resolves from plugins.gradle.org
(not Central), so the existing
`pluginManagement` repository entry in each `settings.gradle` remains
load-bearing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
