mariofusco commented on code in PR #6909:
URL: https://github.com/apache/incubator-kie/pull/6909#discussion_r3935340530


##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/phreak/B.java:
##########
@@ -18,18 +18,30 @@
  */
 package org.drools.mvel.integrationtests.phreak;
 
+import org.kie.api.definition.type.Expires;
 import org.kie.api.definition.type.Position;
+import org.kie.api.definition.type.Role;
+import org.kie.api.definition.type.Role.Type;
 
+@Expires(value = "5s")
+@Role(value = Type.EVENT)

Review Comment:
   If I understand correctly, the test domain objects that you're modifying 
here are shared with other test cases not related with your pull request. I 
guess that this doesn't have any impact on existing tests, but you can consider 
creating separate event subclasses (e.g. `BEvent extends B`) for the sequencing 
tests instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to