Copilot commented on code in PR #4009:
URL:
https://github.com/apache/incubator-kie-tools/pull/4009#discussion_r4023393968
##########
pnpm-lock.yaml:
##########
@@ -6040,7 +6040,7 @@ importers:
version: link:../pmml-editor-marshaller
'@patternfly/react-charts':
specifier: ^7.4.7
- version: 7.4.9([email protected]([email protected]))([email protected])
+ version: 7.4.9
Review Comment:
This resolution now drops `react` and `react-dom`, even though
`@patternfly/react-charts` declares both as required peers (lockfile lines
11822–11824), this importer supplies compatible React 18 (lines 6062–6070), and
PMML imports the chart components at runtime. The corresponding snapshot at
line 27419 also lost both peers, so a pnpm install records them as unresolved.
Regenerate the lockfile from a clean checkout with the pinned pnpm version and
retain the peer-qualified React resolution; the nearby React peer removals
should be corrected in the same regeneration.
##########
packages/vscode-extension-kie-ba-bundle/CHANGELOG.md:
##########
@@ -15,8 +15,15 @@
under the License.
-->
+# 10.3.0
+
+- Added DRL Editor extension (`kie-group.drl-vscode-extension`) to bundle
dependencies.
+- Bump minimum supported VS Code version (`engines.vscode`) to `^1.103.0`.
+
Please refer to:
-
https://marketplace.visualstudio.com/items/kie-group.bpmn-vscode-extension/changelog
-
https://marketplace.visualstudio.com/items/kie-group.dmn-vscode-extension/changelog
+-
https://marketplace.visualstudio.com/items/kie-group.drl-vscode-extension/changelog
-
https://marketplace.visualstudio.com/items/kie-group.extended-services-vscode-extension/changelog
+-
https://marketplace.visualstudio.com/items/kie-group.pmml-vscode-extension/changelog
Review Comment:
This link says PMML is part of the Business Automation bundle, but this
bundle's `extensionDependencies` contains only BPMN, DMN, Extended Services,
and DRL, and its README does not advertise PMML. Remove this unrelated link so
the changelog accurately reflects the extensions installed by the bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
