Copilot commented on code in PR #7122:
URL: https://github.com/apache/incubator-kie/pull/7122#discussion_r4043880092
##########
drools-ruleunits/drools-ruleunits-dsl/src/main/java/org/drools/ruleunits/dsl/patterns/Pattern2DefImpl.java:
##########
@@ -74,16 +74,171 @@ public <V> Pattern2DefImpl<A, B> filter(String fieldName,
Function1<B, V> leftEx
return this;
}
+ @Override
+ public Pattern2DefImpl<A, B> after() {
+ return addTemporalConstraint(DSL.after());
+ }
+
+ @Override
+ public Pattern2DefImpl<A, B> after(long min, TimeUnit unit) {
+ return addTemporalConstraint(DSL.after(min, unit));
+ }
+
@Override
public Pattern2DefImpl<A, B> after(long min, long max, TimeUnit unit) {
return addTemporalConstraint(DSL.after(min, unit, max, unit));
}
+ @Override
+ public Pattern2DefImpl<A, B> before() {
+ return addTemporalConstraint(DSL.before());
+ }
+
+ @Override
+ public Pattern2DefImpl<A, B> before(long min, TimeUnit unit) {
+ return addTemporalConstraint(DSL.before(min, unit));
+ }
+
@Override
public Pattern2DefImpl<A, B> before(long min, long max, TimeUnit unit) {
return addTemporalConstraint(DSL.before(min, unit, max, unit));
}
+ @Override
+ public Pattern2DefImpl<A, B> coincides() {
+ return addTemporalConstraint(DSL.coincides());
Review Comment:
The new operators are only covered by matching scenarios. With the current
company filters, those tests would also pass if an implementation failed to add
any temporal constraint, and the deviation overloads for
`meets`/`metby`/`starts`/`startedby`/`finishes`/`finishedby` are exercised only
at zero deviation. Add non-matching and boundary scenarios so each relation and
its range/deviation arguments are verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
