AnnJoy23 commented on PR #4021: URL: https://github.com/apache/incubator-kie-tools/pull/4021#issuecomment-5828780845
@jomarko Thank you for reviewing! spring.cloud.kubernetes.discovery.enabled=false is not needed here because kie-addons-springboot-kubernetes (and spring-cloud-starter-kubernetes-fabric8) are not on the classpath of this example — there are no Spring Cloud Kubernetes jars to autoconfigure, so the property would have no effect. The only place it appears in this codebase is in the kubernetes addon's own test application.properties, where it suppresses cluster discovery during unit tests. Adding it to an example that doesn't use the kubernetes addon would be misleading. > Is it fine we do not add `spring.cloud.kubernetes.discovery.enabled=false` into https://github.com/AnnJoy23/incubator-kie-tools/tree/8fb3c8be42363dfdd1b6b617e67f603c29770515/examples/process-compact-architecture-springboot ? Thank you for reviewing! spring.cloud.kubernetes.discovery.enabled=false is not needed here because kie-addons-springboot-kubernetes (and spring-cloud-starter-kubernetes-fabric8) are not on the classpath of this example — there are no Spring Cloud Kubernetes jars to autoconfigure, so the property would have no effect. The only place it appears in this codebase is in the kubernetes addon's own test application.properties, where it suppresses cluster discovery during unit tests. Adding it to an example that doesn't use the kubernetes addon would be misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
