drccrd commented on PR #4032: URL: https://github.com/apache/incubator-kie-tools/pull/4032#issuecomment-5954757178
@tkobayas 1: added a configurable timeout (default 2 minutes) 2: fallback added in `fileFor` as suggested 3: I don't think this is actually an issue: setEngine closes only the previously installed engine, never the current one, so with an empty classpath the engine built over the last good classpath stays installed with an open loader. That is intended during a transient Maven failure. setEngine(null) would also throw, since setEngine calls available() and close() on its argument 4: tokens in comments (masked) are now skipped 5 and 6: both addressed in [8abe2b9](https://github.com/apache/incubator-kie-tools/pull/4032/commits/8abe2b901932cd197f7ec15a9a2a0f97749900a4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
