Copilot commented on code in PR #4030: URL: https://github.com/apache/incubator-kie-tools/pull/4030#discussion_r4223152179
########## .github/workflows/ci_java17_compat.yml: ########## @@ -0,0 +1,262 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "CI :: Build (Java 17)" + +on: + push: + branches: [main] + pull_request: + branches: ["**"] + types: [opened, reopened, ready_for_review, synchronize] + +concurrency: + group: ${{ github.event.pull_request && format('ci-build-java17-pr-{0}', github.event.pull_request.number) || format('ci-build-java17-push-main-{0}', github.sha) }} + cancel-in-progress: true + +env: + TMPDIR: "/tmp" + BUILD_ENV__accessErrorsLogFileAbsolutePath: "/tmp/build-env-access-errors.log" + +jobs: + run: + if: github.event.pull_request.draft == false + strategy: + fail-fast: false + matrix: + os: [ubuntu-latest, macos-14, windows-latest] + partition: [0] + runs-on: ${{ matrix.os }} + steps: + - name: "Support longpaths" + if: runner.os == 'Windows' + run: git config --system core.longpaths true + + - name: "Checkout @ GitHub default" + uses: actions/checkout@v3 + + - name: "Checkout @ Simulated squashed-merge if PR" + id: checkout_pr + uses: ./.github/actions/checkout-pr + with: + ref: ${{ github.base_ref }} + + - name: "Setup Node" + uses: actions/setup-node@v4 + with: + node-version: 24.21.0 + + - name: "Setup pnpm" + shell: bash + run: npm -g install [email protected] + + - name: "Setup CI patterns" + id: ci_patterns + uses: ./.github/actions/setup-ci-patterns + + - name: "Setup build mode {none,full,partial}" + id: setup_build_mode + shell: bash + run: | + + npm -g install [email protected] [email protected] + + echo '{}' > turbo.json + + turbo telemetry disable + + bun ./.github/supporting-files/ci/build-partitioning/build_partitioning.ts \ + --outputPath='/tmp/partitions.json' \ + --tmpPartitionFilterPath='/tmp/partition-filter.txt' \ + --forceFull='${{ !github.event.pull_request }}' \ Review Comment: The compatibility workflow does not run the promised full build on pull requests: this expression evaluates to `false` for every PR, so the partitioner selects `partial` or even `none` mode based on changed packages. That can mark the Java 17 check successful without validating the whole repository. Force full mode here to match the stated full-build validation across all three operating systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
