jomarko commented on code in PR #4040:
URL:
https://github.com/apache/incubator-kie-tools/pull/4040#discussion_r4270245896
##########
packages/bpmn-editor/tsconfig.tests.json:
##########
@@ -0,0 +1,3 @@
+{
+ "extends": "./tsconfig.json"
+}
Review Comment:
Not sure I understand this feedback. The same file is present also in other
packages. Also the tests are running:
```
(devbox) jomarko@IBM-4B0SBC4:~/apache/kie-tools$ pnpm -F
@kie-tools/bpmn-editor test
> @kie-tools/[email protected] test
/home/jomarko/apache/kie-tools/packages/bpmn-editor
> run-script-if --ignore-errors "$(build-env tests.ignoreFailures)" --bool
"$(build-env tests.run)" --then "jest --silent --verbose --passWithNoTests"
[run-script-if] Boolean condition supplied.
[run-script-if] Conditions are checked using the operator 'and'.
[run-script-if] Condition is 'true'. Running _then_ command(s).
[run-script-if] Running 1 command(s): ['jest --silent --verbose
--passWithNoTests']
[run-script-if] Running 'jest --silent --verbose --passWithNoTests'
PASS tests/mutations/getBpmnNamespacePrefix.test.ts (7.176 s)
getBpmnNamespacePrefix
✓ returns empty string when definitions is undefined (4 ms)
✓ returns empty string when definitions has no namespace entries (1 ms)
✓ returns empty string when BPMN model namespace is bound to the default
xmlns (no prefix)
✓ returns 'bpmn2:' when BPMN model namespace is bound to the bpmn2 prefix
✓ returns 'bpmn:' when BPMN model namespace is bound to a custom 'bpmn'
prefix
✓ returns empty string when a different namespace is bound to xmlns but
not the BPMN model namespace (1 ms)
✓ ignores non-xmlns keys that happen to have the BPMN model namespace as
value
✓ returns the first matching prefix when multiple xmlns entries are
present
Test Suites: 1 passed, 1 total
Tests: 8 passed, 8 total
Snapshots: 0 total
Time: 7.742 s
[run-script-if] Finished 'jest --silent --verbose --passWithNoTests'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
