mvanhorn opened a new pull request, #7192: URL: https://github.com/apache/incubator-kie/pull/7192
# 1. Build upstream dependencies of your changes (skip tests for speed) A sequential knowledge base aborts rule execution with a NullPointerException when a rule updates a fact that a from binding also reads. Sessions that only insert those facts complete. The from update path loads the previous-match map from the left tuple context and uses it immediately. Sequential mode builds that from node with tuple memory disabled, so the insert path never stores the map and the update path dereferences null. The from update path now throws IllegalStateException when that map is missing, stating that update or modify through a from binding is unsupported while sequential mode has disabled tuple memory. SequentialTest.testSequentialFromNodeUpdate expects that exception for a sequential stateless run that updates a person feeding an address from binding, expects the same rules with sequential mode off to mark the person happy and collect the update and the street, and expects a sequential insert of an already happy person to collect only the street. Fixes #7125 # 2. Build your changed modules and their transitive dependents (with tests) mvn -B -ntp -pl drools-test-coverage/test-compiler-integration -am test -Dtest=SequentialTest -Dsurefire.failIfNoSpecifiedTests=false completed with BUILD SUCCESS. The tests in `drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/sequential/SequentialTest.java` fail without the fix in the incubator-kie PhreakFromNode change (checked by reverting the source changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
