tkobayas opened a new issue, #7221:
URL: https://github.com/apache/incubator-kie/issues/7221
## Problem
Since PHREAK (DROOLS-650, BZ-1228098), `modify`/`update` in the RHS is
supported in sequential mode, and the existing tests under
`org.drools.mvel.integrationtests.sequential` (e.g. `SequentialTest`) mainly
cover `modify`.
There is little or no test coverage for `insert` and `delete` (`retract`) in
the RHS in sequential mode, so their behavior is neither verified nor
documented. The documentation used to say that sequential mode "ignores"
`insert`/`modify`/`update`, which is not accurate (#7210), but the actual
semantics of `insert`/`delete` are not clear.
## What should be done
1. Add tests for `insert` in the RHS in sequential mode, for example:
- A rule that has not been evaluated yet matches a fact inserted by a
previously fired rule.
- A rule that has already been evaluated is not re-evaluated after an
insert.
- Inserted facts joined with existing facts (beta network), with and
without `not`/`exists`/accumulate.
2. Add tests for `delete` in the RHS in sequential mode, for example:
- A rule that has not been evaluated yet no longer matches a deleted fact.
- Deleting a fact that is part of a match of a rule not yet fired.
- Interaction with `not`/`exists`.
3. Combine with `modify`/`update` and with salience/agenda-group ordering
where relevant.
4. If any test reveals an error (NPE, incorrect results, etc.), fix it.
5. Based on the results, the expected semantics of `insert`/`delete` can be
reflected in the sequential mode documentation (#7210).
## Related
- #7210 — Update sequential mode documentation to reflect PHREAK behavior
- #7201 / #7202 — beta node sharing disabled in sequential mode
- #7209 — `@Propagation(IMMEDIATE)` / `@Propagation(EAGER)` ignored in
sequential mode
- DROOLS-650 — modify support in sequential mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
