tkobayas commented on code in PR #7220:
URL: https://github.com/apache/incubator-kie/pull/7220#discussion_r4356554774
##########
drools-core/src/main/java/org/drools/core/reteoo/builder/ReteooRuleBuilder.java:
##########
@@ -120,6 +124,10 @@ public List<TerminalNode> addRule(InternalRuleBase kBase,
Collection<InternalWor
// transform rule and gets the array of subrules
final GroupElement[] subrules = rule.getTransformedLhs(
LogicTransformer.getInstance(), kBase.getGlobals() );
+ if (kBase.getRuleBaseConfiguration().isSequential() &&
rule.isDataDriven()) {
+ log.warn("@Propagation(IMMEDIATE) on rule '{}' is ignored in
sequential mode", rule.getName());
+ }
Review Comment:
`RuleImpl.setDataDriven(true)` is only called for `@Propagation(IMMEDIATE)`
(`RuleBuilder` for DRL, `KiePackagesBuilder` for the executable model), so the
message is accurate. `ForceEagerActivationOption` is a session option and isn't
known at kbase build time, so it isn't covered by this warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
