Kusuma04-dev commented on code in PR #4053:
URL:
https://github.com/apache/incubator-kie-tools/pull/4053#discussion_r4369794223
##########
packages/scesim-editor-envelope/src/TestScenarioEditorRoot.tsx:
##########
@@ -113,8 +122,7 @@ export class TestScenarioEditorRoot extends
React.Component<TestScenarioEditorRo
openFileNormalizedPosixPathRelativeToTheWorkspaceRoot: string,
content: string
): Promise<void> {
- const marshaller = getMarshaller(content || EMPTY_ONE_EIGHT);
- const scesimModel = marshaller.parser.parse();
+ const marshaller = this.getMarshaller(content);
Review Comment:
@yesamer The empty-content case is still covered: getMarshallerAndModel
keeps getMarshaller(content || EMPTY_ONE_EIGHT), so a new, empty scenario opens
with the empty structure as before.
I also removed the duplicate parse, so the file is now parsed once, and I
verified that creating a new .scesim still opens correctly. I have shared you
.vsix , Please re-verify once. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
