ch-lukas commented on PR #3652: URL: https://github.com/apache/incubator-kie-tools/pull/3652#issuecomment-6603041835
Thanks @yesamer! Rebased on main, conflicts are sorted. Addressed the Copilot comments too - `getBorderMidpointTowards` now computes the facing border midpoint itself rather than passing the node in twice, and `getShapeBoundsById` filters on `bpmndi:BPMNShape`. Also added the missing asserts in the e2e test. The only one I didn't change is the module-level model in the story - kept it that way since it matches the existing `Empty.stories`, but shout if you'd prefer otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
