SAY-5 opened a new pull request, #7295: URL: https://github.com/apache/incubator-kie/pull/7295
**Thank you for submitting this pull request** **NOTE!:** Double-check the target branch for this PR. The default is `main`. **Ports** If a forward-port or a backport is needed, paste the forward port PR here * none **Issue**: _(please edit the GitHub Issues link if it exists)_ * https://github.com/apache/incubator-kie/issues/7238 **Referenced Pull Requests**: _(please edit the URLs of referenced pull requests if they exist)_ * none On a discrete domain an EQ entry is mapped to `[v .. next value)`, but a comparison such as `<= 0` comes in as an open range and was kept as `[0 .. 0]`, so with inputValues `0, 2, 4` the rules `<= 0` and `>= 2` reported a gap `( 0 .. 2 )` (and `0` with `> 0` reported an overlap there). Intervals of such entries are now expressed by the discrete values they include, the same way as for EQ; rules outside the domain are still reported as before. Added `NoGapsSparseNumericDomainTest` with the model from the issue, which fails without the change. <details> <summary> How to replicate the CI locally </summary> The CI does "simple" maven build(s). All commands can be run from the repository root. **Quick build of just your changed modules and their dependents** (mirrors what CI does on a PR): ```shell # 1. Build upstream dependencies of your changes (skip tests for speed) mvn -T 1C --batch-mode -fae -DskipTests -DskipITs \ -Denforcer.skip=true -Dcheckstyle.skip=true -Dformatter.skip=true -Darchunit.skip=true \ -pl <upstream-modules> install # 2. Build your changed modules and their transitive dependents (with tests) mvn --batch-mode -fae -Dreproducible \ -pl <affected-modules> install ``` To compute `<upstream-modules>` and `<affected-modules>` automatically (requires [JBang](https://www.jbang.dev/)): ```shell jbang script/ci/CiComputeBuildScopes.java \ <changed-files.txt> \ <upstream-modules.txt> \ <affected-modules.txt> \ <changed-modules.txt> ``` **Full build** (equivalent to what runs on every push to `main`): ```shell mvn --batch-mode -fae -Dfull -Dreproducible install ``` `-Dfull` additionally builds the distribution modules and generates Javadoc JARs. **Useful flags:** | Flag | Effect | |---|---| | `-Dquickly` | Skip tests, Checkstyle, formatter, Enforcer, ArchUnit | | `-DskipTests` | Skip unit tests | | `-DskipITs` | Skip integration tests | | `-Denforcer.skip=true` | Skip Enforcer plugin | | `-Dcheckstyle.skip=true` | Skip Checkstyle | | `-Dformatter.skip=true` | Skip formatter | | `-Darchunit.skip=true` | Skip ArchUnit | </details> <details> <summary> How to retest this PR or trigger a specific build </summary> - To **re-run CI**: push a new commit to the PR (an empty commit is enough: `git commit --allow-empty -m "re-trigger CI"`). </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
