jhaabhijeet864 opened a new issue, #4081:
URL: https://github.com/apache/incubator-kie-tools/issues/4081

   In `packages/bpmn-marshaller/src/schemas/bpmn-2_0/Bpmn20Spec.ts`, the 
`isValidName` function always returns `true`. It does not check whether the 
name is actually valid, so invalid names are accepted.
   
   The function should check the name and return `false` when the name is not 
valid.
   
   ```typescript
   export const BPMN20_SPEC = {
     isValidName: (id: string, name: string | undefined, allUniqueNames: 
UniqueNameIndex): boolean => {
       return true; // FIXME: Tiago: Implement (valid name)
     },
   };
   ```
   The function literally returns true every time, with a FIXME comment saying 
it still needs to be implemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to