This is an automated email from the ASF dual-hosted git repository.

yesamer pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie.git


The following commit(s) were added to refs/heads/main by this push:
     new 036692f2aea [incubator-kie#7286] Fix rules with more than 32 segments 
never firing (#7296)
036692f2aea is described below

commit 036692f2aead5f6eb4451649bb3a4283e7b9bec5
Author: Toni Rikkola <[email protected]>
AuthorDate: Tue Nov 17 10:36:57 2026 +0200

    [incubator-kie#7286] Fix rules with more than 32 segments never firing 
(#7296)
    
    A rule whose path through the rule network is split into more than 32 
segments was silently skipped by the engine: it never fired and no error was 
reported. A path is split into a new segment wherever rules share a prefix of 
their conditions and then diverge, so a set of rules with long common prefixes 
can reach this limit.
    
    Each segment gets a bit in a mask that records whether the segment is 
linked (ready to evaluate). The bit was calculated with a 32-bit int, while the 
mask it is merged into is a 64-bit long. From the 33rd segment on, the shift 
overflowed to 0, so these segments could never be marked as linked and the rule 
never became active.
    
    Calculate the segment position bits as long in BuildtimeSegmentUtilities, 
SegmentMemorySupportImpl and EagerPhreakBuilder (1L << i instead of 1 << i).
    
    Add SegmentPosMaskOverflowTest, which builds 40 rules sharing a common 
prefix (the longest has 39 segments) and checks that all of them fire. Before 
the fix, rules 33 to 39 did not fire. The test includes a 'not' pattern at the 
position of segment 32, because the int bit for segment 31 is negative and 
sign-extends into the upper 32 bits of the long, which hides the overflow for 
the segments after it.
    
    Assisted-by: IBM Bob
---
 .../core/phreak/BuildtimeSegmentUtilities.java     |   2 +-
 .../org/drools/core/phreak/EagerPhreakBuilder.java |   6 +-
 .../core/phreak/SegmentMemorySupportImpl.java      |   2 +-
 .../SegmentPosMaskOverflowTest.java                | 100 +++++++++++++++++++++
 4 files changed, 105 insertions(+), 5 deletions(-)

diff --git 
a/drools-core/src/main/java/org/drools/core/phreak/BuildtimeSegmentUtilities.java
 
b/drools-core/src/main/java/org/drools/core/phreak/BuildtimeSegmentUtilities.java
index 90322386dbc..e4c7b75c5e7 100644
--- 
a/drools-core/src/main/java/org/drools/core/phreak/BuildtimeSegmentUtilities.java
+++ 
b/drools-core/src/main/java/org/drools/core/phreak/BuildtimeSegmentUtilities.java
@@ -166,7 +166,7 @@ public class BuildtimeSegmentUtilities {
         } while (segmentRoot != null); // it's after lian
 
         // reset to find the next segments and set their position and their 
bit mask
-        int ruleSegmentPosMask = 1;
+        long ruleSegmentPosMask = 1L;
         for (int i = 0; i < smems.size(); i++) {
             if (start >= 0 && smems.get(i) != null) { // The segments before 
the start of a subnetwork, will be null for a TupleToObjectNode path.
                 smems.get(i).setPos(i);
diff --git 
a/drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java 
b/drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java
index d05aefa55c5..ebf5df1857a 100644
--- a/drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java
+++ b/drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java
@@ -471,7 +471,7 @@ public class EagerPhreakBuilder implements PhreakBuilder {
                     for (int i = proto2.getPos() + 1; i < newList.length; i++) 
{
                         newList[i] = oldList[i - 1];
                         newList[i].setPos(i);
-                        newList[i].setSegmentPosMaskBit(1 << i);
+                        newList[i].setSegmentPosMaskBit(1L << i);
                     }
                 }
                 endNode.setSegmentPrototypes(newList);
@@ -748,7 +748,7 @@ public class EagerPhreakBuilder implements PhreakBuilder {
                 if (proto1.getPos() + 1 != newList.length) {
                     for (int i = proto1.getPos() + 1; i < newList.length; i++) 
{
                         newList[i].setPos(i);
-                        newList[i].setSegmentPosMaskBit(1 << i);
+                        newList[i].setSegmentPosMaskBit(1L << i);
                     }
                 }
                 endNode.setSegmentPrototypes(newList);
@@ -1301,7 +1301,7 @@ public class EagerPhreakBuilder implements PhreakBuilder {
                         }
                     } else {
                         // ensure the pmem is unset for this position, can 
happen if the segment that set this before shifted up
-                        pmem.setLinkedSegmentMask(pmem.getLinkedSegmentMask() 
& ~(1 << i));
+                        pmem.setLinkedSegmentMask(pmem.getLinkedSegmentMask() 
& ~(1L << i));
                     }
                 }
                 pmem.setSegmentMemories(newSmems);
diff --git 
a/drools-core/src/main/java/org/drools/core/phreak/SegmentMemorySupportImpl.java
 
b/drools-core/src/main/java/org/drools/core/phreak/SegmentMemorySupportImpl.java
index 79271c7018b..a19ecbd0a8c 100644
--- 
a/drools-core/src/main/java/org/drools/core/phreak/SegmentMemorySupportImpl.java
+++ 
b/drools-core/src/main/java/org/drools/core/phreak/SegmentMemorySupportImpl.java
@@ -498,7 +498,7 @@ public class SegmentMemorySupportImpl implements 
SegmentMemorySupport {
 
         // iterate to find root and determine the SegmentNodes position in the 
RuleSegment
         LeftTupleSource pathRoot = segmentRoot;
-        int ruleSegmentPosMask = 1;
+        long ruleSegmentPosMask = 1L;
         int counter = 0;
         while (!NodeTypeEnums.isLeftInputAdapterNode(pathRoot)) {
             LeftTupleSource leftTupleSource = pathRoot.getLeftTupleSource();
diff --git 
a/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/SegmentPosMaskOverflowTest.java
 
b/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/SegmentPosMaskOverflowTest.java
new file mode 100644
index 00000000000..ffb24966eb3
--- /dev/null
+++ 
b/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/SegmentPosMaskOverflowTest.java
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.drools.compiler.integrationtests;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import org.drools.testcoverage.common.util.KieBaseTestConfiguration;
+import org.drools.testcoverage.common.util.KieBaseUtil;
+import org.drools.testcoverage.common.util.TestParametersUtil2;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+import org.kie.api.KieBase;
+import org.kie.api.runtime.KieSession;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class SegmentPosMaskOverflowTest {
+
+    private static final int RULE_COUNT = 40;
+
+    private static final int NOT_PATTERN_INDEX = 32;
+
+    public static Stream<KieBaseTestConfiguration> parameters() {
+        return 
TestParametersUtil2.getKieBaseCloudConfigurations(true).stream();
+    }
+
+    private static String buildDrl() {
+        StringBuilder drl = new StringBuilder();
+        drl.append("package 
org.drools.compiler.integrationtests.segmentposmask;\n");
+        drl.append("global java.util.List results;\n");
+        for (int rule = 0; rule < RULE_COUNT; rule++) {
+            drl.append("rule \"rule").append(rule).append("\"\n");
+            drl.append("when\n");
+            for (int pattern = 0; pattern <= rule; pattern++) {
+                if (pattern == 0) {
+                    drl.append("    $first : Integer( this == 0 )\n");
+                } else if (pattern == NOT_PATTERN_INDEX) {
+                    drl.append("    not Long( this == $first )\n");
+                } else {
+                    drl.append("    Integer( this == 
").append(pattern).append(" )\n");
+                }
+            }
+            drl.append("then\n");
+            drl.append("    results.add(\"rule").append(rule).append("\");\n");
+            drl.append("end\n");
+        }
+        return drl.toString();
+    }
+
+    @ParameterizedTest(name = "KieBase type={0}")
+    @MethodSource("parameters")
+    public void testRuleWithMoreThan32SegmentsFires(KieBaseTestConfiguration 
cfg) {
+        String drl = buildDrl();
+
+        KieBase kbase = 
KieBaseUtil.getKieBaseFromKieModuleFromDrl("segment-pos-mask-overflow", cfg, 
drl);
+        KieSession ks = kbase.newKieSession();
+        try {
+            List<String> results = new ArrayList<>();
+            ks.setGlobal("results", results);
+
+            for (int i = 0; i < RULE_COUNT; i++) {
+                if (i != NOT_PATTERN_INDEX) {
+                    ks.insert(i);
+                }
+            }
+            ks.fireAllRules();
+
+            Set<String> expected = new HashSet<>();
+            for (int rule = 0; rule < RULE_COUNT; rule++) {
+                expected.add("rule" + rule);
+            }
+
+            assertThat(results)
+                    .as("Every rule must fire once its patterns are 
satisfied.")
+                    .containsExactlyInAnyOrderElementsOf(expected);
+        } finally {
+            ks.dispose();
+        }
+    }
+}


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to