jhaabhijeet864 commented on PR #4083: URL: https://github.com/apache/incubator-kie-tools/pull/4083#issuecomment-6999614483
Hi @drccrd, Thank you for the detailed and constructive review. I have refactored the implementation to address all feedback: 1. **Comment Token Parsing**: Suppression directives are now parsed directly from ANTLR comment tokens (`COMMENT`, `LINE_COMMENT`, `RHS_COMMENT`, `RHS_LINE_COMMENT`) during document parse/validation, avoiding string-blanking regex heuristics and addressing quote handling inside comments. 2. **Deprecation Suppression & Stable Codes**: Assigned stable codes to all deprecation families in `DeprecatedConstructs` (`half-constraint`, `pattern-connective`, `lhs-connective-annotation`, `agenda-group`, `custom-operator`). Claimed lines remain registered to avoid syntax error resurfacing on suppression. 3. **Diagnostic Cap Preservation**: Suppressed diagnostics are filtered prior to incrementing per-pass diagnostic counters so they do not exhaust the 20/50 caps. 4. **Action & Code Validation**: Directives match full action identifiers to prevent hyphen boundary issues, and emit warning diagnostics for unrecognized directive actions or diagnostic codes. 5. **Stack-Based Rule Boundaries**: Shared rule scanning with `lintMissingRuleEnds` to handle unclosed rule stacks with case-sensitive keyword checks, ensuring unclosed rules do not swallow subsequent blocks. 6. **Multi-Line Block Comment Anchoring**: Multi-line block comments (`/* ... */`) using `disable-next-line` now target the line directly following the closing `*/`. 7. **Region State Modeling**: Regional suppression is modeled as an exclusion set (`allExcept(reEnabledCodes)`), cleanly supporting partial re-enablement after wildcard disable without a hardcoded code inventory. 8. **Quick-Fix Suppression Alignment**: MVEL property access actions respect the suppression index to prevent rewriting suppressed getters. 9. **Documentation**: Added directive reference and diagnostic codes tables to `packages/drl-vscode-extension/README.md`. All unit tests in both `drools-completion` and `drools-lsp-server` pass. Please take a look when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
