Repository: knox Updated Branches: refs/heads/master 8ea911cc1 -> 437a9a883
KNOX-1324 - Remote Configuration Monitor should not log stacktrace when client is not configured Project: http://git-wip-us.apache.org/repos/asf/knox/repo Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/437a9a88 Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/437a9a88 Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/437a9a88 Branch: refs/heads/master Commit: 437a9a88323d0973ebdd135115ba23f8a20a6d81 Parents: 8ea911c Author: Phil Zampino <pzamp...@apache.org> Authored: Fri May 18 10:50:52 2018 -0400 Committer: Phil Zampino <pzamp...@apache.org> Committed: Fri May 18 10:50:52 2018 -0400 ---------------------------------------------------------------------- .../src/main/java/org/apache/knox/gateway/GatewayMessages.java | 4 +--- .../gateway/services/topology/impl/DefaultTopologyService.java | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/knox/blob/437a9a88/gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java b/gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java index b4a0adb..743b958 100644 --- a/gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java +++ b/gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java @@ -559,9 +559,7 @@ public interface GatewayMessages { @StackTrace( level = MessageLevel.DEBUG ) Exception e ); @Message( level = MessageLevel.WARN, text = "An error occurred while attempting to start the remote configuration monitor {0} : {1}" ) - void remoteConfigurationMonitorStartFailure(final String monitorType, - final String errorMessage, - @StackTrace( level = MessageLevel.DEBUG ) Exception e ); + void remoteConfigurationMonitorStartFailure(final String monitorType, final String errorMessage); @Message( level = MessageLevel.INFO, text = "Starting remote configuration monitor for source {0} ..." ) void startingRemoteConfigurationMonitor(final String address); http://git-wip-us.apache.org/repos/asf/knox/blob/437a9a88/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java b/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java index ab5cedf..7482389 100644 --- a/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java +++ b/gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java @@ -540,7 +540,7 @@ public class DefaultTopologyService try { remoteMonitor.start(); } catch (Exception e) { - log.remoteConfigurationMonitorStartFailure(remoteMonitor.getClass().getTypeName(), e.getLocalizedMessage(), e); + log.remoteConfigurationMonitorStartFailure(remoteMonitor.getClass().getTypeName(), e.getLocalizedMessage()); } } }
