Repository: knox Updated Branches: refs/heads/master d6e93fef9 -> 19166412f
KNOX-1429 - HadoopAuthFilter avoid logging sensitive values Signed-off-by: Kevin Risden <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/knox/repo Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/19166412 Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/19166412 Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/19166412 Branch: refs/heads/master Commit: 19166412f24ee76abf11140fff952f0beab7f592 Parents: d6e93fe Author: Kevin Risden <[email protected]> Authored: Thu Oct 11 10:02:39 2018 -0400 Committer: Kevin Risden <[email protected]> Committed: Thu Oct 11 14:51:58 2018 -0400 ---------------------------------------------------------------------- .../knox/gateway/hadoopauth/HadoopAuthMessages.java | 3 --- .../knox/gateway/hadoopauth/filter/HadoopAuthFilter.java | 11 ++--------- 2 files changed, 2 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/knox/blob/19166412/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/HadoopAuthMessages.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/HadoopAuthMessages.java b/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/HadoopAuthMessages.java index c8c94b0..2a92d36 100755 --- a/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/HadoopAuthMessages.java +++ b/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/HadoopAuthMessages.java @@ -24,9 +24,6 @@ import org.apache.knox.gateway.i18n.messages.Messages; @Messages(logger="org.apache.knox.gateway.provider.global.hadoopauth") public interface HadoopAuthMessages { - @Message( level = MessageLevel.INFO, text = "Initializing Hadoop Auth Property, name: {0}, value: {1}" ) - void initializingHadoopAuthProperty(String name, String value); - @Message( level = MessageLevel.DEBUG, text = "Hadoop Authentication Asserted Principal: {0}" ) void hadoopAuthAssertedPrincipal(String name); http://git-wip-us.apache.org/repos/asf/knox/blob/19166412/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java b/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java index 321560e..44cafbc 100755 --- a/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java +++ b/gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java @@ -23,9 +23,6 @@ import java.util.Properties; import javax.servlet.FilterConfig; import javax.servlet.ServletException; -import org.apache.knox.gateway.hadoopauth.HadoopAuthMessages; -import org.apache.knox.gateway.i18n.messages.MessagesFactory; - /* * see http://hadoop.apache.org/docs/current/hadoop-auth/Configuration.html * @@ -48,21 +45,17 @@ import org.apache.knox.gateway.i18n.messages.MessagesFactory; public class HadoopAuthFilter extends org.apache.hadoop.security.authentication.server.AuthenticationFilter { - private static HadoopAuthMessages log = MessagesFactory.get( HadoopAuthMessages.class ); - @Override protected Properties getConfiguration(String configPrefix, FilterConfig filterConfig) throws ServletException { Properties props = new Properties(); - Enumeration<?> names = filterConfig.getInitParameterNames(); + Enumeration<String> names = filterConfig.getInitParameterNames(); while (names.hasMoreElements()) { - String name = (String) names.nextElement(); + String name = names.nextElement(); if (name.startsWith(configPrefix)) { String value = filterConfig.getInitParameter(name); - log.initializingHadoopAuthProperty(name, value); props.put(name.substring(configPrefix.length()), value); } } return props; } - }
