Repository: knox Updated Branches: refs/heads/master a46a232b7 -> b8ddf1e32
KNOX-1538 - Remove TODO Auto-generated Signed-off-by: Kevin Risden <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/knox/repo Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/b8ddf1e3 Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/b8ddf1e3 Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/b8ddf1e3 Branch: refs/heads/master Commit: b8ddf1e32161fe9091ce539541dbd5ba210108ae Parents: a46a232 Author: Kevin Risden <[email protected]> Authored: Tue Oct 23 09:36:46 2018 -0400 Committer: Kevin Risden <[email protected]> Committed: Tue Oct 23 10:09:32 2018 -0400 ---------------------------------------------------------------------- .../JWTAccessTokenAssertionContributor.java | 1 - .../filter/JWTAccessTokenAssertionFilter.java | 1 - .../jwt/filter/JWTAuthCodeAssertionFilter.java | 1 - .../federation/AbstractJWTFilterTest.java | 12 ++------ .../gateway/pac4j/session/KnoxSessionStore.java | 3 -- .../preauth/filter/PreAuthFederationFilter.java | 1 - .../webappsec/filter/CSRFPreventionFilter.java | 1 - .../security/impl/DefaultCryptoService.java | 4 --- .../services/security/impl/JettySSLService.java | 4 --- .../services/security/CryptoServiceTest.java | 6 ---- .../service/vault/CredentialResource.java | 2 -- .../VaultServiceDeploymentContributor.java | 1 - .../security/impl/CMFKeystoreService.java | 31 ++++---------------- .../security/impl/CMFMasterService.java | 1 - .../services/security/token/impl/JWTToken.java | 1 - .../security/impl/CMFKeystoreServiceTest.java | 14 ++------- .../security/impl/CMFMasterServiceTest.java | 1 - .../apache/knox/gateway/GatewayTestConfig.java | 3 -- 18 files changed, 11 insertions(+), 77 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/deploy/JWTAccessTokenAssertionContributor.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/deploy/JWTAccessTokenAssertionContributor.java b/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/deploy/JWTAccessTokenAssertionContributor.java index af67407..946446e 100644 --- a/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/deploy/JWTAccessTokenAssertionContributor.java +++ b/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/deploy/JWTAccessTokenAssertionContributor.java @@ -46,7 +46,6 @@ public class JWTAccessTokenAssertionContributor extends @Override public void initializeContribution(DeploymentContext context) { - // TODO Auto-generated method stub super.initializeContribution(context); crypto.createAndStoreEncryptionKeyForCluster(GATEWAY, ENCRYPT_ACCESS_TOKENS); } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java b/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java index 4588345..f26c61b 100644 --- a/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java +++ b/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAccessTokenAssertionFilter.java @@ -144,7 +144,6 @@ public class JWTAccessTokenAssertionFilter extends AbstractIdentityAssertionFilt @Override public String getName() { - // TODO Auto-generated method stub return principalName; } }; http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java b/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java index b2dcb3d..c6abc9c 100644 --- a/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java +++ b/gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java @@ -92,7 +92,6 @@ public class JWTAuthCodeAssertionFilter extends AbstractIdentityAssertionFilter response.getWriter().write(jsonResponse); //KNOX-685: response.getWriter().flush(); } catch (TokenServiceException e) { - // TODO Auto-generated catch block e.printStackTrace(); } return; // break filter chain http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/AbstractJWTFilterTest.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/AbstractJWTFilterTest.java b/gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/AbstractJWTFilterTest.java index 6d21308..1ef2c1b 100644 --- a/gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/AbstractJWTFilterTest.java +++ b/gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/AbstractJWTFilterTest.java @@ -786,9 +786,7 @@ public abstract class AbstractJWTFilterTest { * @see JWTokenAuthority#issueToken(javax.security.auth.Subject, java.lang.String) */ @Override - public JWT issueToken(Subject subject, String algorithm) - throws TokenServiceException { - // TODO Auto-generated method stub + public JWT issueToken(Subject subject, String algorithm) throws TokenServiceException { return null; } @@ -796,9 +794,7 @@ public abstract class AbstractJWTFilterTest { * @see JWTokenAuthority#issueToken(java.security.Principal, java.lang.String) */ @Override - public JWT issueToken(Principal p, String algorithm) - throws TokenServiceException { - // TODO Auto-generated method stub + public JWT issueToken(Principal p, String algorithm) throws TokenServiceException { return null; } @@ -839,9 +835,7 @@ public abstract class AbstractJWTFilterTest { * @see JWTokenAuthority#issueToken(java.security.Principal, java.lang.String, long) */ @Override - public JWT issueToken(Principal p, String algorithm, long expires) - throws TokenServiceException { - // TODO Auto-generated method stub + public JWT issueToken(Principal p, String algorithm, long expires) throws TokenServiceException { return null; } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java b/gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java index 67da829..fc02277 100644 --- a/gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java +++ b/gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java @@ -180,19 +180,16 @@ public class KnoxSessionStore implements SessionStore { @Override public SessionStore buildFromTrackableSession(WebContext arg0, Object arg1) { - // TODO Auto-generated method stub return null; } @Override public boolean destroySession(WebContext arg0) { - // TODO Auto-generated method stub return false; } @Override public Object getTrackableSession(WebContext arg0) { - // TODO Auto-generated method stub return null; } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-preauth/src/main/java/org/apache/knox/gateway/preauth/filter/PreAuthFederationFilter.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-preauth/src/main/java/org/apache/knox/gateway/preauth/filter/PreAuthFederationFilter.java b/gateway-provider-security-preauth/src/main/java/org/apache/knox/gateway/preauth/filter/PreAuthFederationFilter.java index 60b59c9..841d11a 100644 --- a/gateway-provider-security-preauth/src/main/java/org/apache/knox/gateway/preauth/filter/PreAuthFederationFilter.java +++ b/gateway-provider-security-preauth/src/main/java/org/apache/knox/gateway/preauth/filter/PreAuthFederationFilter.java @@ -74,7 +74,6 @@ public class PreAuthFederationFilter implements Filter { */ @Override public void destroy() { - // TODO Auto-generated method stub } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/filter/CSRFPreventionFilter.java ---------------------------------------------------------------------- diff --git a/gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/filter/CSRFPreventionFilter.java b/gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/filter/CSRFPreventionFilter.java index 5b4b18c..c03798f 100644 --- a/gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/filter/CSRFPreventionFilter.java +++ b/gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/filter/CSRFPreventionFilter.java @@ -70,7 +70,6 @@ public class CSRFPreventionFilter implements Filter { */ @Override public void destroy() { - // TODO Auto-generated method stub } } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultCryptoService.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultCryptoService.java b/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultCryptoService.java index 33e2bd6..3cb09e7 100644 --- a/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultCryptoService.java +++ b/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultCryptoService.java @@ -66,13 +66,11 @@ public class DefaultCryptoService implements CryptoService { @Override public void start() throws ServiceLifecycleException { - // TODO Auto-generated method stub } @Override public void stop() throws ServiceLifecycleException { - // TODO Auto-generated method stub } @@ -81,7 +79,6 @@ public class DefaultCryptoService implements CryptoService { try { as.generateAliasForCluster(clusterName, alias); } catch (AliasServiceException e) { - // TODO Auto-generated catch block e.printStackTrace(); } } @@ -92,7 +89,6 @@ public class DefaultCryptoService implements CryptoService { try { password = as.getPasswordFromAliasForCluster(clusterName, alias); } catch (AliasServiceException e2) { - // TODO Auto-generated catch block e2.printStackTrace(); } if (password != null) { http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java b/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java index dc5774c..c90fbf7 100644 --- a/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java +++ b/gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java @@ -235,14 +235,10 @@ public class JettySSLService implements SSLService { @Override public void start() throws ServiceLifecycleException { - // TODO Auto-generated method stub - } @Override public void stop() throws ServiceLifecycleException { - // TODO Auto-generated method stub - } private static KeyStore loadKeyStore( String fileName, String storeType, char[] storePass ) throws CertificateException, NoSuchAlgorithmException, IOException, KeyStoreException { http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-server/src/test/java/org/apache/knox/gateway/services/security/CryptoServiceTest.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/test/java/org/apache/knox/gateway/services/security/CryptoServiceTest.java b/gateway-server/src/test/java/org/apache/knox/gateway/services/security/CryptoServiceTest.java index 10ac93f..141c7d2 100644 --- a/gateway-server/src/test/java/org/apache/knox/gateway/services/security/CryptoServiceTest.java +++ b/gateway-server/src/test/java/org/apache/knox/gateway/services/security/CryptoServiceTest.java @@ -80,19 +80,15 @@ public class CryptoServiceTest { @Override public char[] getPasswordFromAliasForGateway(String alias) { - // TODO Auto-generated method stub return null; } @Override public void generateAliasForGateway(String alias) { - // TODO Auto-generated method stub - } @Override public Certificate getCertificateForGateway(String alias) { - // TODO Auto-generated method stub return null; } @@ -102,13 +98,11 @@ public class CryptoServiceTest { @Override public List<String> getAliasesForCluster(String clusterName) { - // TODO Auto-generated method stub return null; } @Override public char[] getGatewayIdentityPassphrase() throws AliasServiceException { - // TODO Auto-generated method stub return null; } }; http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/CredentialResource.java ---------------------------------------------------------------------- diff --git a/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/CredentialResource.java b/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/CredentialResource.java index 99a5813..73c9859 100644 --- a/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/CredentialResource.java +++ b/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/CredentialResource.java @@ -85,7 +85,6 @@ public class CredentialResource { try { aliases = as.getAliasesForCluster(clusterName); } catch (AliasServiceException e) { - // TODO Auto-generated catch block e.printStackTrace(); } return aliases; @@ -104,7 +103,6 @@ public class CredentialResource { try { credential = as.getPasswordFromAliasForCluster(clusterName, alias); } catch (AliasServiceException e) { - // TODO Auto-generated catch block e.printStackTrace(); } if (credential != null) { http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/deploy/VaultServiceDeploymentContributor.java ---------------------------------------------------------------------- diff --git a/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/deploy/VaultServiceDeploymentContributor.java b/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/deploy/VaultServiceDeploymentContributor.java index c9120c5..f46d58f 100644 --- a/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/deploy/VaultServiceDeploymentContributor.java +++ b/gateway-service-vault/src/main/java/org/apache/knox/gateway/service/vault/deploy/VaultServiceDeploymentContributor.java @@ -29,7 +29,6 @@ public class VaultServiceDeploymentContributor extends JerseyServiceDeploymentCo */ @Override public String getRole() { - // TODO Auto-generated method stub return "VAULT"; } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreService.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreService.java b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreService.java index 2d87f29..623314e 100644 --- a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreService.java +++ b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreService.java @@ -81,13 +81,9 @@ public class CMFKeystoreService extends BaseKeystoreService { } else { throw new IOException("Unable to open gateway keystore."); } - } catch (NoSuchAlgorithmException e) { + } catch (IOException | GeneralSecurityException e) { LOG.failedToAddSeflSignedCertForGateway(alias, e); - } catch (GeneralSecurityException e) { - LOG.failedToAddSeflSignedCertForGateway(alias, e); - } catch (IOException e) { - LOG.failedToAddSeflSignedCertForGateway(alias, e); - } + } } public void createCredentialStore() throws KeystoreServiceException { @@ -99,9 +95,7 @@ public class CMFKeystoreService extends BaseKeystoreService { final File keyStoreFile = new File( keyStoreDir + serviceName + CREDENTIALS_SUFFIX ); try { return isKeystoreAvailable(keyStoreFile, "JCEKS"); - } catch (KeyStoreException e) { - throw new KeystoreServiceException(e); - } catch (IOException e) { + } catch (KeyStoreException | IOException e) { throw new KeystoreServiceException(e); } } @@ -110,9 +104,7 @@ public class CMFKeystoreService extends BaseKeystoreService { final File keyStoreFile = new File( keyStoreDir + serviceName + ".jks" ); try { return isKeystoreAvailable(keyStoreFile, "JKS"); - } catch (KeyStoreException e) { - throw new KeystoreServiceException(e); - } catch (IOException e) { + } catch (KeyStoreException | IOException e) { throw new KeystoreServiceException(e); } } @@ -123,12 +115,7 @@ public class CMFKeystoreService extends BaseKeystoreService { if (ks != null) { try { key = ks.getKey(alias, passphrase); - } catch (UnrecoverableKeyException e) { - // TODO Auto-generated catch block - LOG.failedToGetKey(alias, e); - } catch (KeyStoreException e) { - LOG.failedToGetKey(alias, e); - } catch (NoSuchAlgorithmException e) { + } catch (UnrecoverableKeyException | KeyStoreException | NoSuchAlgorithmException e) { LOG.failedToGetKey(alias, e); } } @@ -146,13 +133,7 @@ public class CMFKeystoreService extends BaseKeystoreService { final File keyStoreFile = new File( keyStoreDir + serviceName + CREDENTIALS_SUFFIX ); try { writeKeystoreToFile(ks, keyStoreFile); - } catch (KeyStoreException e) { - LOG.failedToAddCredential(e); - } catch (NoSuchAlgorithmException e) { - LOG.failedToAddCredential(e); - } catch (CertificateException e) { - LOG.failedToAddCredential(e); - } catch (IOException e) { + } catch (KeyStoreException | NoSuchAlgorithmException | CertificateException | IOException e) { LOG.failedToAddCredential(e); } } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFMasterService.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFMasterService.java b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFMasterService.java index bed4a08..4bae4b1 100644 --- a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFMasterService.java +++ b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/CMFMasterService.java @@ -152,7 +152,6 @@ public class CMFMasterService { } private EncryptionResult encryptMaster(char[] master) { - // TODO Auto-generated method stub try { return encryptor.encrypt(new String(master)); } catch (Exception e) { http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java index a5be576..258625b 100644 --- a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java +++ b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java @@ -271,7 +271,6 @@ public class JWTToken implements JWT { try { rc = jwt.verify(verifier); } catch (JOSEException e) { - // TODO Auto-generated catch block log.unableToVerifyToken(e); } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java b/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java index 2a85b3b..b7109d6 100644 --- a/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java +++ b/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java @@ -55,28 +55,18 @@ public class CMFKeystoreServiceTest { public void init(GatewayConfig config, Map<String, String> options) throws ServiceLifecycleException { - // TODO Auto-generated method stub - } - public void start() throws ServiceLifecycleException { - // TODO Auto-generated method stub - - } + public void start() throws ServiceLifecycleException {} - public void stop() throws ServiceLifecycleException { - // TODO Auto-generated method stub - - } + public void stop() throws ServiceLifecycleException {} public char[] getMasterSecret() { - // TODO Auto-generated method stub return "testmaster".toCharArray(); } }); } catch (ServiceLifecycleException e) { - // TODO Auto-generated catch block e.printStackTrace(); } } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFMasterServiceTest.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFMasterServiceTest.java b/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFMasterServiceTest.java index 5d95204..c4a17da 100644 --- a/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFMasterServiceTest.java +++ b/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFMasterServiceTest.java @@ -51,7 +51,6 @@ public class CMFMasterServiceTest { assertTrue(file.exists()); file.delete(); } catch (ServiceLifecycleException e) { - // TODO Auto-generated catch block e.printStackTrace(); fail(); } http://git-wip-us.apache.org/repos/asf/knox/blob/b8ddf1e3/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java ---------------------------------------------------------------------- diff --git a/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java b/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java index 98e2d33..f7339d6 100644 --- a/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java +++ b/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java @@ -258,7 +258,6 @@ public class GatewayTestConfig extends Configuration implements GatewayConfig { */ @Override public boolean isClientAuthNeeded() { - // TODO Auto-generated method stub return false; } @@ -267,7 +266,6 @@ public class GatewayTestConfig extends Configuration implements GatewayConfig { */ @Override public String getTruststorePath() { - // TODO Auto-generated method stub return null; } @@ -276,7 +274,6 @@ public class GatewayTestConfig extends Configuration implements GatewayConfig { */ @Override public boolean getTrustAllCerts() { - // TODO Auto-generated method stub return false; }
