[knox] branch master updated: KNOX-2285 - Change gateway.server.header.enabled default to false

[krisden]

This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git


The following commit(s) were added to refs/heads/master by this push:
     new 27a8113  KNOX-2285 - Change gateway.server.header.enabled default to 
false
27a8113 is described below

commit 27a8113ca02f14f66aefd8238c13b79249a94b25
Author: Kevin Risden <kris...@apache.org>
AuthorDate: Tue Mar 10 16:25:00 2020 -0400

    KNOX-2285 - Change gateway.server.header.enabled default to false
    
    Signed-off-by: Kevin Risden <kris...@apache.org>
---
 .../java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java | 2 +-
 .../org/apache/knox/gateway/config/impl/GatewayConfigImplTest.java  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
 
b/gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
index 18397c2..60f0a01 100644
--- 
a/gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
+++ 
b/gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
@@ -950,7 +950,7 @@ public class GatewayConfigImpl extends Configuration 
implements GatewayConfig {
 
   @Override
   public boolean isGatewayServerHeaderEnabled() {
-    return Boolean.parseBoolean(getVar(SERVER_HEADER_ENABLED, "true"));
+    return Boolean.parseBoolean(getVar(SERVER_HEADER_ENABLED, "false"));
   }
 
   @Override
diff --git 
a/gateway-server/src/test/java/org/apache/knox/gateway/config/impl/GatewayConfigImplTest.java
 
b/gateway-server/src/test/java/org/apache/knox/gateway/config/impl/GatewayConfigImplTest.java
index 2958cb5..3e418b5 100644
--- 
a/gateway-server/src/test/java/org/apache/knox/gateway/config/impl/GatewayConfigImplTest.java
+++ 
b/gateway-server/src/test/java/org/apache/knox/gateway/config/impl/GatewayConfigImplTest.java
@@ -221,11 +221,11 @@ public class GatewayConfigImplTest {
     boolean serverHeaderEnabled;
 
     serverHeaderEnabled = config.isGatewayServerHeaderEnabled();
-    assertThat( serverHeaderEnabled, is(true));
+    assertThat( serverHeaderEnabled, is(false));
 
-    config.set( GatewayConfigImpl.SERVER_HEADER_ENABLED, "false");
+    config.set( GatewayConfigImpl.SERVER_HEADER_ENABLED, "true");
     serverHeaderEnabled = config.isGatewayServerHeaderEnabled();
-    assertThat( serverHeaderEnabled, is(false));
+    assertThat( serverHeaderEnabled, is(true));
   }