This is an automated email from the ASF dual-hosted git repository.

smolnar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git


The following commit(s) were added to refs/heads/master by this push:
     new 29efc4149 KNOX-2814 - Run shellcheck for GitHub Actions too (#646)
29efc4149 is described below

commit 29efc4149d461938bc4c517bec07b95e704ef5aa
Author: Sandor Molnar <[email protected]>
AuthorDate: Tue Oct 4 14:39:54 2022 +0200

    KNOX-2814 - Run shellcheck for GitHub Actions too (#646)
---
 .github/workflows/main.yml     | 8 +-------
 gateway-release-common/pom.xml | 1 -
 gateway-release/pom.xml        | 1 -
 gateway-shell-release/pom.xml  | 1 -
 4 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 7fbe76efc..9907fabef 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -40,10 +40,4 @@ jobs:
         with:
           java-version: ${{ matrix.java }}
       - name: 'Build and Test'
-        run: mvn -T.75C clean verify -U -Dsurefire.useFile=false 
-Djavax.net.ssl.trustStorePassword=changeit 
-Dmaven.wagon.http.retryHandler.count=5 
-Dmaven.wagon.http.retryHandler.class=default 
-Dmaven.wagon.http.retryHandler.nonRetryableClasses=java.io.InterruptedIOException
 -Dhttp.keepAlive=false -B -V
-# This is failing due to not finding files? - See KNOX-2347
-#      - name: shellcheck
-#        uses: reviewdog/action-shellcheck@v1
-#        with:
-#          pattern: "*release*/home/bin/*.sh"
-
+        run: mvn -T.75C clean verify -U -Dsurefire.useFile=false 
-Dshellcheck=true -Djavax.net.ssl.trustStorePassword=changeit 
-Dmaven.wagon.http.retryHandler.count=5 
-Dmaven.wagon.http.retryHandler.class=default 
-Dmaven.wagon.http.retryHandler.nonRetryableClasses=java.io.InterruptedIOException
 -Dhttp.keepAlive=false -B -V
diff --git a/gateway-release-common/pom.xml b/gateway-release-common/pom.xml
index 12bb18396..8488d6709 100644
--- a/gateway-release-common/pom.xml
+++ b/gateway-release-common/pom.xml
@@ -32,7 +32,6 @@
   
   <profiles>
         <profile>
-           <!-- Running this profile require you to have the 'shellcheck' tool 
installed on your DEV environment. Check out 
https://github.com/koalaman/shellcheck#installing for more information -->
            <activation>
                <property>
                    <name>shellcheck</name>
diff --git a/gateway-release/pom.xml b/gateway-release/pom.xml
index 5de943006..bb66ce034 100644
--- a/gateway-release/pom.xml
+++ b/gateway-release/pom.xml
@@ -169,7 +169,6 @@
             </build>
         </profile>
         <profile>
-           <!-- Running this profile require you to have the 'shellcheck' tool 
installed on your DEV environment. Check out 
https://github.com/koalaman/shellcheck#installing for more information -->
            <activation>
                <property>
                    <name>shellcheck</name>
diff --git a/gateway-shell-release/pom.xml b/gateway-shell-release/pom.xml
index 131220004..6fff809b8 100644
--- a/gateway-shell-release/pom.xml
+++ b/gateway-shell-release/pom.xml
@@ -169,7 +169,6 @@
             </build>
         </profile>
         <profile>
-           <!-- Running this profile require you to have the 'shellcheck' tool 
installed on your DEV environment. Check out 
https://github.com/koalaman/shellcheck#installing for more information -->
            <activation>
                <property>
                    <name>shellcheck</name>

Reply via email to