Repository: kudu Updated Branches: refs/heads/master c6994d19c -> 09b1e09cb
[java client] KuduScanToken#build cleanup Using Todd's patch for error-prone, I found that KuduScanToken#build was not only doing unnecessary comparisons but also that the fields we were setting were going to be overwritten anyways. Change-Id: I732bb8c2178056ae16adc2e76782b8743833fee2 Reviewed-on: http://gerrit.cloudera.org:8080/4430 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/09b1e09c Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/09b1e09c Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/09b1e09c Branch: refs/heads/master Commit: 09b1e09cb5f896f48ed7e27015488d48b66718e3 Parents: c6994d1 Author: Jean-Daniel Cryans <jdcry...@apache.org> Authored: Thu Sep 15 17:25:51 2016 -0700 Committer: Jean-Daniel Cryans <jdcry...@apache.org> Committed: Fri Sep 16 14:57:27 2016 +0000 ---------------------------------------------------------------------- .../src/main/java/org/apache/kudu/client/KuduScanToken.java | 6 ------ 1 file changed, 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/09b1e09c/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java ---------------------------------------------------------------------- diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java index ceee464..9f603ad 100644 --- a/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java +++ b/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java @@ -297,12 +297,6 @@ public class KuduScanToken implements Comparable<KuduScanToken> { if (upperBoundPrimaryKey.length > 0) { proto.setUpperBoundPrimaryKey(ZeroCopyLiteralByteString.copyFrom(upperBoundPrimaryKey)); } - if (lowerBoundPartitionKey.length > 0) { - proto.setLowerBoundPartitionKey(ZeroCopyLiteralByteString.copyFrom(lowerBoundPartitionKey)); - } - if (upperBoundPartitionKey.length > 0) { - proto.setUpperBoundPartitionKey(ZeroCopyLiteralByteString.copyFrom(upperBoundPartitionKey)); - } proto.setLimit(limit); proto.setReadMode(readMode.pbVersion());
