[java] Fix bug in RegexpKuduOperationsProducer I've been experimenting with using FindBugs. It's not ready, but it found a bug in an error path of the regexp OperationsProducer that I want to fix quickly.
Change-Id: I1807790fad39ed0d3b22e0e94e06858dd8abceda Reviewed-on: http://gerrit.cloudera.org:8080/5032 Reviewed-by: Mike Percy <[email protected]> Tested-by: Kudu Jenkins Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/b1b6c88e Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/b1b6c88e Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/b1b6c88e Branch: refs/heads/master Commit: b1b6c88e3e55fe2fe3eed9012425388d21bd92b4 Parents: 6b60bfd Author: Will Berkeley <[email protected]> Authored: Thu Nov 10 10:01:18 2016 -0500 Committer: Will Berkeley <[email protected]> Committed: Thu Nov 10 15:30:14 2016 +0000 ---------------------------------------------------------------------- .../org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/b1b6c88e/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java ---------------------------------------------------------------------- diff --git a/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java b/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java index c4de305..b905ef1 100644 --- a/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java +++ b/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java @@ -147,7 +147,7 @@ public class RegexpKuduOperationsProducer implements KuduOperationsProducer { pattern = Pattern.compile(regexp); } catch (PatternSyntaxException e) { throw new IllegalArgumentException( - String.format("The pattern '%s' is invalid", PATTERN_PROP, regexp), e); + String.format("The pattern '%s' is invalid", regexp), e); } String charsetName = context.getString(ENCODING_PROP, DEFAULT_ENCODING); try {
