Repository: kudu Updated Branches: refs/heads/master edf36ebe0 -> c19f30225
Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT We no longer use GROUP_VARINT for encoding user data, since it only supports unsigned ints, and we don't expose unsigned int types to users anymore. So, it makes more sense to use signed ints with BIT_SHUFFLE for this test. Change-Id: I4c2b7727e1147ac86db0ba2d97640220938149ea Reviewed-on: http://gerrit.cloudera.org:8080/5168 Reviewed-by: Dan Burkert <[email protected]> Tested-by: Kudu Jenkins Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/447330c1 Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/447330c1 Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/447330c1 Branch: refs/heads/master Commit: 447330c1d4ce5000ba44d8fea42d8d56e66c9c1e Parents: edf36eb Author: Todd Lipcon <[email protected]> Authored: Mon Nov 21 14:15:10 2016 -0800 Committer: Todd Lipcon <[email protected]> Committed: Tue Nov 29 21:45:58 2016 +0000 ---------------------------------------------------------------------- src/kudu/cfile/cfile-test.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/447330c1/src/kudu/cfile/cfile-test.cc ---------------------------------------------------------------------- diff --git a/src/kudu/cfile/cfile-test.cc b/src/kudu/cfile/cfile-test.cc index 50d7846..0cb121c 100644 --- a/src/kudu/cfile/cfile-test.cc +++ b/src/kudu/cfile/cfile-test.cc @@ -352,8 +352,8 @@ TEST_P(TestCFileBothCacheTypes, TestWrite100MFileInts) { BlockId block_id; LOG_TIMING(INFO, "writing 100m ints") { LOG(INFO) << "Starting writefile"; - UInt32DataGenerator<false> generator; - WriteTestFile(&generator, GROUP_VARINT, NO_COMPRESSION, 100000000, NO_FLAGS, &block_id); + Int32DataGenerator<false> generator; + WriteTestFile(&generator, BIT_SHUFFLE, NO_COMPRESSION, 100000000, NO_FLAGS, &block_id); LOG(INFO) << "Done writing"; } @@ -370,7 +370,7 @@ TEST_P(TestCFileBothCacheTypes, TestWrite100MFileNullableInts) { BlockId block_id; LOG_TIMING(INFO, "writing 100m nullable ints") { LOG(INFO) << "Starting writefile"; - UInt32DataGenerator<true> generator; + Int32DataGenerator<true> generator; WriteTestFile(&generator, PLAIN_ENCODING, NO_COMPRESSION, 100000000, NO_FLAGS, &block_id); LOG(INFO) << "Done writing"; }
