Repository: kudu Updated Branches: refs/heads/master 10aeb2877 -> 0c1b52fdf
log-rolling-itest: delete test files when test ends By not inheriting from the KuduTest fixture, this test didn't clean up after itself. Normally this is caught in build-and-test.sh by the TEST_TMPDIR contents check, but precommit jobs use dist-test so the check only looks at local files. Change-Id: Ia099401229bbb1d0e3bdf0580c50ae78e49e4b0e Reviewed-on: http://gerrit.cloudera.org:8080/7100 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/0c1b52fd Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/0c1b52fd Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/0c1b52fd Branch: refs/heads/master Commit: 0c1b52fdf9d0707e98395ef04aa851609c26e0cf Parents: 10aeb28 Author: Adar Dembo <[email protected]> Authored: Tue Jun 6 17:58:46 2017 -0700 Committer: David Ribeiro Alves <[email protected]> Committed: Wed Jun 7 14:21:17 2017 +0000 ---------------------------------------------------------------------- src/kudu/integration-tests/log-rolling-itest.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/0c1b52fd/src/kudu/integration-tests/log-rolling-itest.cc ---------------------------------------------------------------------- diff --git a/src/kudu/integration-tests/log-rolling-itest.cc b/src/kudu/integration-tests/log-rolling-itest.cc index 6397233..59c774a 100644 --- a/src/kudu/integration-tests/log-rolling-itest.cc +++ b/src/kudu/integration-tests/log-rolling-itest.cc @@ -35,6 +35,8 @@ using strings::Substitute; namespace kudu { +class LogRollingITest : public KuduTest {}; + static int64_t CountInfoLogs(const string& log_dir) { vector<string> logfiles; string pattern = Substitute("$0/*.$1.*", log_dir, "INFO"); @@ -43,7 +45,7 @@ static int64_t CountInfoLogs(const string& log_dir) { } // Tests that logs roll on startup, and get cleaned up appropriately. -TEST(LogRollingITest, TestLogCleanupOnStartup) { +TEST_F(LogRollingITest, TestLogCleanupOnStartup) { ExternalMiniClusterOptions opts; opts.num_masters = 1; opts.num_tablet_servers = 0;
