Fix misc-string-* clang-tidy warnings Change-Id: I7f2dcb07813c1e3ba15e60f1f3b688d5b1e41c4f Reviewed-on: http://gerrit.cloudera.org:8080/7132 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/8e04eebc Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/8e04eebc Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/8e04eebc Branch: refs/heads/master Commit: 8e04eebc61944169a3910fa1029e0e9364a3886d Parents: 66a33a0 Author: Todd Lipcon <[email protected]> Authored: Thu Jun 8 19:14:53 2017 -0700 Committer: Todd Lipcon <[email protected]> Committed: Fri Jun 9 23:05:08 2017 +0000 ---------------------------------------------------------------------- src/kudu/client/predicate-test.cc | 2 +- src/kudu/gutil/strings/join.cc | 2 +- src/kudu/util/group_varint-test.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/8e04eebc/src/kudu/client/predicate-test.cc ---------------------------------------------------------------------- diff --git a/src/kudu/client/predicate-test.cc b/src/kudu/client/predicate-test.cc index 76bf4c4..ac38511 100644 --- a/src/kudu/client/predicate-test.cc +++ b/src/kudu/client/predicate-test.cc @@ -220,7 +220,7 @@ class PredicateTest : public KuduTest { // Returns a vector of string values. vector<string> CreateStringValues() { return { - string("", 0), + string(), string("\0", 1), string("\0\0", 2), string("a", 1), http://git-wip-us.apache.org/repos/asf/kudu/blob/8e04eebc/src/kudu/gutil/strings/join.cc ---------------------------------------------------------------------- diff --git a/src/kudu/gutil/strings/join.cc b/src/kudu/gutil/strings/join.cc index c0035e1..8907792 100644 --- a/src/kudu/gutil/strings/join.cc +++ b/src/kudu/gutil/strings/join.cc @@ -188,7 +188,7 @@ void JoinCSVLineWithDelimiter(const vector<string>& cols, char delimiter, CHECK_GE(size, escaped_size + 3) << "Buffer should have one space at the beginning for a " << "double-quote, one at the end for a double-quote, and " - << "one at the end for a closing '\0'"; + << "one at the end for a closing '\\0'"; *buf.get() = '"'; *((buf.get() + 1) + escaped_size) = '"'; *((buf.get() + 1) + escaped_size + 1) = '\0'; http://git-wip-us.apache.org/repos/asf/kudu/blob/8e04eebc/src/kudu/util/group_varint-test.cc ---------------------------------------------------------------------- diff --git a/src/kudu/util/group_varint-test.cc b/src/kudu/util/group_varint-test.cc index 62176ef..c5ff410 100644 --- a/src/kudu/util/group_varint-test.cc +++ b/src/kudu/util/group_varint-test.cc @@ -41,7 +41,7 @@ static void DoTestRoundTripGVI32( // so append some extra padding data to ensure that it's not reading // uninitialized memory. The SSE implementation uses 128-bit reads // and the non-SSE one uses 32-bit reads. - buf.append(string('x', use_sse ? 16 : 4)); + buf.append(string(use_sse ? 16 : 4, 'x')); uint32_t ret[4];
