Repository: kudu Updated Branches: refs/heads/master e68a7953a -> b4de65a8a
external_mini_cluster: use a default destructor for options struct If a non-default destructor is defined, then the implicit move constructor won't be defined, and our use of std::move() when instantiating ExternalMiniCluster causes a clang-tidy warning. Change-Id: I66f931b9b79f4be07f33692d6a10854340a9f19d Reviewed-on: http://gerrit.cloudera.org:8080/7165 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Dan Burkert <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/312492d5 Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/312492d5 Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/312492d5 Branch: refs/heads/master Commit: 312492d55e57a89a527e949b5cc191b7714f01c6 Parents: e68a795 Author: Todd Lipcon <[email protected]> Authored: Mon Jun 12 19:01:28 2017 -0700 Committer: Todd Lipcon <[email protected]> Committed: Tue Jun 13 22:41:57 2017 +0000 ---------------------------------------------------------------------- src/kudu/integration-tests/external_mini_cluster.cc | 3 --- src/kudu/integration-tests/external_mini_cluster.h | 1 - 2 files changed, 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/312492d5/src/kudu/integration-tests/external_mini_cluster.cc ---------------------------------------------------------------------- diff --git a/src/kudu/integration-tests/external_mini_cluster.cc b/src/kudu/integration-tests/external_mini_cluster.cc index ef15ab9..c0edca4 100644 --- a/src/kudu/integration-tests/external_mini_cluster.cc +++ b/src/kudu/integration-tests/external_mini_cluster.cc @@ -101,9 +101,6 @@ ExternalMiniClusterOptions::ExternalMiniClusterOptions() start_process_timeout(MonoDelta::FromSeconds(30)) { } -ExternalMiniClusterOptions::~ExternalMiniClusterOptions() { -} - ExternalMiniCluster::ExternalMiniCluster() : opts_(ExternalMiniClusterOptions()) { } http://git-wip-us.apache.org/repos/asf/kudu/blob/312492d5/src/kudu/integration-tests/external_mini_cluster.h ---------------------------------------------------------------------- diff --git a/src/kudu/integration-tests/external_mini_cluster.h b/src/kudu/integration-tests/external_mini_cluster.h index edcc41e..7f275cb 100644 --- a/src/kudu/integration-tests/external_mini_cluster.h +++ b/src/kudu/integration-tests/external_mini_cluster.h @@ -55,7 +55,6 @@ class ServerStatusPB; struct ExternalMiniClusterOptions { ExternalMiniClusterOptions(); - ~ExternalMiniClusterOptions(); // Number of masters to start. // Default: 1
