Repository: kudu
Updated Branches:
  refs/heads/master c8a1c0f97 -> 194fd8b16


thirdparty: disable the gperftools heap checker

We haven't used this feature in several years -- we now use ASAN's leak
sanitizer to look for memory leaks.

Change-Id: I7acbc9623a21bf0a961ebe8b83163d18c4289e11
Reviewed-on: http://gerrit.cloudera.org:8080/9258
Reviewed-by: Alexey Serbin <aser...@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/526ee849
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/526ee849
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/526ee849

Branch: refs/heads/master
Commit: 526ee84976e89293cff744b1c94e3e663174ef70
Parents: c8a1c0f
Author: Todd Lipcon <t...@apache.org>
Authored: Thu Feb 8 11:47:43 2018 -0800
Committer: Todd Lipcon <t...@apache.org>
Committed: Fri Feb 9 19:57:46 2018 +0000

----------------------------------------------------------------------
 build-support/parse_test_failure.py | 13 -------------
 thirdparty/build-definitions.sh     |  1 -
 2 files changed, 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/526ee849/build-support/parse_test_failure.py
----------------------------------------------------------------------
diff --git a/build-support/parse_test_failure.py 
b/build-support/parse_test_failure.py
index fd9f8c7..c0ca766 100755
--- a/build-support/parse_test_failure.py
+++ b/build-support/parse_test_failure.py
@@ -36,7 +36,6 @@ ASAN_ERROR_RE = re.compile('ERROR: AddressSanitizer')
 TSAN_ERROR_RE = re.compile('WARNING: ThreadSanitizer.*')
 END_TSAN_ERROR_RE = re.compile('SUMMARY: ThreadSanitizer.*')
 FATAL_LOG_RE = re.compile(r'^F\d\d\d\d \d\d:\d\d:\d\d\.\d\d\d\d\d\d\s+\d+ 
(.*)')
-LEAK_CHECK_SUMMARY_RE = re.compile('Leak check.*detected leaks')
 LINE_RE = re.compile(r"^.*$", re.MULTILINE)
 STACKTRACE_ELEM_RE = re.compile(r'^    @')
 IGNORED_STACKTRACE_ELEM_RE = re.compile(
@@ -128,18 +127,6 @@ def extract_failures(log_text):
       error_signature += "\n".join(remaining_lines)
       record_error(errors_by_test, cur_test_case, error_signature)
 
-    # Look for leak check summary (comes at the end of a log, not part of a 
single test)
-    m = LEAK_CHECK_SUMMARY_RE.search(line)
-    if m:
-      heapcheck_test_case = "tcmalloc.heapcheck"
-      if heapcheck_test_case not in tests_seen:
-        tests_seen.add(heapcheck_test_case)
-        tests_seen_in_order.append(heapcheck_test_case)
-      error_signature = "Memory leak\n"
-      error_signature += line + "\n"
-      error_signature += "\n".join(consume_rest(line_iter))
-      record_error(errors_by_test, heapcheck_test_case, error_signature)
-
   # Sometimes we see crashes that the script doesn't know how to parse.
   # When that happens, we leave a generic message to be picked up by Jenkins.
   if cur_test_case and cur_test_case not in errors_by_test:

http://git-wip-us.apache.org/repos/asf/kudu/blob/526ee849/thirdparty/build-definitions.sh
----------------------------------------------------------------------
diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index e38d54a..c13a3e1 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -312,7 +312,6 @@ build_gperftools() {
     LIBS="$EXTRA_LIBS" \
     $GPERFTOOLS_SOURCE/configure \
     --enable-frame-pointers \
-    --enable-heap-checker \
     --with-pic \
     --prefix=$PREFIX
   fixup_libtool

Reply via email to