Repository: kudu
Updated Branches:
  refs/heads/master 0dc19bfb3 -> f5ffcb4d7


[kudu-backup] fix tests

- Previously TestKuduBackup class wasn't executed in
  ./gradlew test, ./gradlew :kudu-backup:test, mvn test, ...

- TestKuduBackup#testRandomBackupAndRestore was failed in
  a column of Type.BINARY

Change-Id: I073963965b2af76a92d6a8bde71af9d758a14c76
Reviewed-on: http://gerrit.cloudera.org:8080/11328
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <granthe...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/30abac02
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/30abac02
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/30abac02

Branch: refs/heads/master
Commit: 30abac028604f4d1fefab9e7e3729715bfedbc74
Parents: 0dc19bf
Author: Kiyoshi Mizumaru <kiyoshi.mizum...@gmail.com>
Authored: Sat Aug 25 21:10:24 2018 +0900
Committer: Grant Henke <granthe...@apache.org>
Committed: Sat Aug 25 19:39:34 2018 +0000

----------------------------------------------------------------------
 .../src/main/scala/org/apache/kudu/backup/TableMetadata.scala     | 2 +-
 .../src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala    | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/30abac02/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
----------------------------------------------------------------------
diff --git 
a/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala 
b/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
index 77cf919..acb9fb4 100644
--- a/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
+++ b/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
@@ -269,7 +269,7 @@ object TableMetadata {
       case Type.FLOAT => value.toFloat
       case Type.DOUBLE => value.toDouble
       case Type.STRING => value
-      case Type.BINARY => Base64.decodeBase64(value.asInstanceOf[Array[Byte]])
+      case Type.BINARY => Base64.decodeBase64(value)
       case Type.DECIMAL => new BigDecimal(value) // TODO: Explicitly pass scale
       case _ =>
         throw new IllegalArgumentException(s"Unsupported column type: 
$colType")

http://git-wip-us.apache.org/repos/asf/kudu/blob/30abac02/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
----------------------------------------------------------------------
diff --git 
a/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala 
b/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
index 9ff9960..4c4e5f0 100644
--- 
a/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
+++ 
b/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
@@ -38,15 +38,12 @@ import org.apache.kudu.spark.kudu._
 import org.apache.kudu.util.DecimalUtil
 import org.junit.Assert._
 import org.junit.Test
-import org.junit.runner.RunWith
-import org.scalatest.junit.JUnitRunner
 import org.slf4j.Logger
 import org.slf4j.LoggerFactory
 
 import scala.collection.JavaConverters._
 import scala.util.Random
 
-@RunWith(classOf[JUnitRunner])
 class TestKuduBackup extends KuduTestSuite {
   val log: Logger = LoggerFactory.getLogger(getClass)
 

Reply via email to