This is an automated email from the ASF dual-hosted git repository. adar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 3175ed07df9c9280adec08fea18d15acbd45a4dc Author: Will Berkeley <[email protected]> AuthorDate: Thu Apr 4 10:31:13 2019 -0700 Enable tcmalloc heap sampling by default This enables tcmalloc heap sampling by default with `--heap-sample-every-n-bytes` set to 512KiB. This will allow users to use the `pprof` tool to gather tcmalloc heap profiles from running Kudu processes, at the cost of some overheard in memory allocation. I've been doing a lot of performance testing on a cluster with heap sampling enabled at this frequency and I don't think the overhead is a problem. Enabling this soon after the release of 1.9 gives us lots of time to run this configuration in tests to see if it causes any problems. Change-Id: I99e06bdd04ecde030383709682cf096b5e5191c9 Reviewed-on: http://gerrit.cloudera.org:8080/12933 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Will Berkeley <[email protected]> --- src/kudu/util/flags.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/kudu/util/flags.cc b/src/kudu/util/flags.cc index 047c893..b966a44 100644 --- a/src/kudu/util/flags.cc +++ b/src/kudu/util/flags.cc @@ -85,14 +85,12 @@ DEFINE_string(heap_profile_path, "", "Output path to store heap profiles. If not TAG_FLAG(heap_profile_path, stable); TAG_FLAG(heap_profile_path, advanced); -DEFINE_int64(heap_sample_every_n_bytes, 0, +DEFINE_int64(heap_sample_every_n_bytes, 512 * 1024, "Enable heap occupancy sampling. If this flag is set to some positive " "value N, a memory allocation will be sampled approximately every N bytes. " "Lower values of N incur larger overhead but give more accurate results. " - "A value such as 524288 (512KB) is a reasonable choice with relatively " - "low overhead."); + "A value such as 512KB is a reasonable choice with relatively low overhead."); TAG_FLAG(heap_sample_every_n_bytes, advanced); -TAG_FLAG(heap_sample_every_n_bytes, experimental); #endif DEFINE_bool(disable_core_dumps, false, "Disable core dumps when this process crashes.");
