This is an automated email from the ASF dual-hosted git repository. adar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git
commit f43257c353d75fbd5d21e323b0b413b45ca9ed8b Author: Alexey Serbin <[email protected]> AuthorDate: Tue Dec 17 12:23:32 2019 -0800 [fs] fix compilation warnings with gcc4.9.2 on CentOS While compiling with GCC 4.9.2 and devtoolset, the warnings were: devtoolset-3/root/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:76:2: warning: delete called on non-final 'kudu::fs::DataDirManager' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor] delete __ptr; ^ devtoolset-3/root/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<kudu::fs::DataDirManager>::operator()' requested here get_deleter()(__ptr); ^ devtoolset-3/root/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:76:2: warning: delete called on 'kudu::fs::Dir' that is abstract but has non-virtual destructor [-Wdelete-abstract-non-virtual-dtor] delete __ptr; ^ devtoolset-3/root/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<kudu::fs::Dir>::operator()' requested here get_deleter()(__ptr); ^ With this patch, the warnings are gone. This patch doesn't contain any functional modifications. Change-Id: I86dbe0ea88709fd79b350a4fca60c7ea1b913e4f Reviewed-on: http://gerrit.cloudera.org:8080/14918 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- src/kudu/fs/dir_manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kudu/fs/dir_manager.h b/src/kudu/fs/dir_manager.h index 864b828..e1beae0 100644 --- a/src/kudu/fs/dir_manager.h +++ b/src/kudu/fs/dir_manager.h @@ -99,7 +99,7 @@ class Dir { std::string dir, std::unique_ptr<DirInstanceMetadataFile> metadata_file, std::unique_ptr<ThreadPool> pool); - ~Dir(); + virtual ~Dir(); // Shuts down this dir's thread pool, waiting for any closures submitted via // ExecClosure() to finish first. @@ -216,7 +216,7 @@ class DirManager { // Returns the root names from the input 'root_list'. static std::vector<std::string> GetRootNames(const CanonicalizedRootsList& root_list); - ~DirManager(); + virtual ~DirManager(); // Shuts down all directories' thread pools. void Shutdown();
