[kudu] branch master updated: [thirdparty] drop unused libcurl features

[alexey]

This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ba4edc  [thirdparty] drop unused libcurl features
2ba4edc is described below

commit 2ba4edcd454f9362591d1df4fa6dda148d7cae62
Author: Alexey Serbin <ale...@apache.org>
AuthorDate: Tue Jan 28 17:03:13 2020 -0800

    [thirdparty] drop unused libcurl features
    
    Build libcurl in thirdparty without extra features.  By default, libcurl
    is configured to be built with a lot of functionality, but the majority
    of those features are not needed in the scope of using libcurl in Kudu
    tests and other simple scenarios (like cloud instance auto-detection).
    
    Change-Id: Ie0e85bec26d3c0e5a4600f564d35c020df996427
    Reviewed-on: http://gerrit.cloudera.org:8080/15124
    Reviewed-by: Adar Dembo <a...@cloudera.com>
    Tested-by: Kudu Jenkins
---
 thirdparty/build-definitions.sh | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/thirdparty/build-definitions.sh b/thirdparty/build-definitions.sh
index 576007c..cf2e546 100644
--- a/thirdparty/build-definitions.sh
+++ b/thirdparty/build-definitions.sh
@@ -650,8 +650,6 @@ build_mustache() {
 }
 
 build_curl() {
-  # Configure for a fairly minimal install - we only use this for testing
-  # so we just need HTTP/HTTPS with GSSAPI support (for SPNEGO testing).
   CURL_BDIR=$TP_BUILD_DIR/$CURL_NAME$MODE_SUFFIX
   mkdir -p $CURL_BDIR
   pushd $CURL_BDIR
@@ -666,15 +664,25 @@ build_curl() {
     export KRB5CONFIG=$KRB5CONFIG_LOCATION
   fi
 
-  # Note: curl shows a message asking for CPPFLAGS to be used for include
-  # directories, not CFLAGS.
+  # In the scope of using libcurl in Kudu tests and other simple scenarios,
+  # not so much functionality is needed as of now, so configure for a fairly
+  # minimal install. For testing, we need HTTP/HTTPS with GSSAPI support
+  # (GSSAPI is needed for SPNEGO testing). Also, cookies might be useful
+  # to test the new functionality introduced in Impala's embedded Web server
+  # recently if Kudu is to pick up the new functionality as well.
+  #
+  # NOTE: curl shows a message asking for CPPFLAGS to be used for include
+  #       directories, not CFLAGS.
+  #
   CFLAGS="$EXTRA_CFLAGS" \
     CPPFLAGS="$EXTRA_CPPFLAGS $OPENSSL_CFLAGS" \
     LDFLAGS="$EXTRA_LDFLAGS $OPENSSL_LDFLAGS" \
     LIBS="$EXTRA_LIBS" \
     $CURL_SOURCE/configure \
     --prefix=$PREFIX \
+    --disable-alt-svc \
     --disable-dict \
+    --disable-doh \
     --disable-file \
     --disable-ftp \
     --disable-gopher \
@@ -682,9 +690,15 @@ build_curl() {
     --disable-ipv6 \
     --disable-ldap \
     --disable-ldaps \
+    --disable-libcurl-option \
     --disable-manual \
+    --disable-mime \
+    --disable-netrc \
+    --disable-parsedate \
     --disable-pop3 \
+    --disable-progress-meter \
     --disable-rtsp \
+    --disable-smb \
     --disable-smtp \
     --disable-telnet \
     --disable-tftp \